Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers

2016-12-08 Thread Christopher Bostic
On Wed, Dec 7, 2016 at 5:33 PM, Jeremy Kerr wrote: > Hi Greg, > >> Why not just create lib/crc4.c with these functions, like the other crc >> functions in the kernel? > > Two (bad) reasons: > > - The crc4 implementation here is pretty specific to the FSI >usage (only supporting 4-bit-sized ch

Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers

2016-12-07 Thread Jeremy Kerr
Hi Greg, > Why not just create lib/crc4.c with these functions, like the other crc > functions in the kernel? Two (bad) reasons: - The crc4 implementation here is pretty specific to the FSI usage (only supporting 4-bit-sized chunks), to keep the math & lookup table simple - I'm lazy So

Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers

2016-12-07 Thread Greg KH
On Tue, Dec 06, 2016 at 08:09:31PM -0600, Chris Bostic wrote: > From: Jeremy Kerr > > Add some helpers for the crc checks for the slave configuration table. > This works 4-bits-at-a-time, using a simple table approach. > > We will need this in the FSI core code, as well as any master > implement

[PATCH 08/16] drivers/fsi: Add crc4 helpers

2016-12-06 Thread Chris Bostic
From: Jeremy Kerr Add some helpers for the crc checks for the slave configuration table. This works 4-bits-at-a-time, using a simple table approach. We will need this in the FSI core code, as well as any master implementations that need to calculate CRCs in software. Signed-off-by: Jeremy Kerr