Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-22 Thread Linus Walleij
On Thu, Mar 17, 2016 at 4:28 PM, Marc Zyngier wrote: > On 17/03/16 15:13, Jon Hunter wrote: struct irq_chip { + struct device *parent; >>> >>> Nit: Please don't call this just "parent". We have parent fields in >>> irq_data and irq_domain structures, and they always are a pointer t

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-21 Thread Jon Hunter
On 18/03/16 17:52, Grygorii Strashko wrote: > On 03/18/2016 04:56 PM, Jon Hunter wrote: >> >> On 18/03/16 14:40, Jon Hunter wrote: >>> On 18/03/16 14:23, Grygorii Strashko wrote: On 03/18/2016 02:27 PM, Jon Hunter wrote: > > On 18/03/16 11:11, Grygorii Strashko wrote: >> >> [snip] >>

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-20 Thread Grygorii Strashko
On 03/18/2016 04:56 PM, Jon Hunter wrote: > > On 18/03/16 14:40, Jon Hunter wrote: >> On 18/03/16 14:23, Grygorii Strashko wrote: >>> On 03/18/2016 02:27 PM, Jon Hunter wrote: On 18/03/16 11:11, Grygorii Strashko wrote: > > [snip] > >>> oh :( That will require updating of all drivers (

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-20 Thread Jon Hunter
On 18/03/16 14:40, Jon Hunter wrote: > On 18/03/16 14:23, Grygorii Strashko wrote: >> On 03/18/2016 02:27 PM, Jon Hunter wrote: >>> >>> On 18/03/16 11:11, Grygorii Strashko wrote: [snip] >> oh :( That will require updating of all drivers (and if it will be taken >> into account that >> wakeup c

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-19 Thread Jon Hunter
On 18/03/16 11:11, Grygorii Strashko wrote: > Hi Jon, > > On 03/17/2016 04:19 PM, Jon Hunter wrote: >> Some IRQ chips may be located in a power domain outside of the CPU >> subsystem and hence will require device specific runtime power >> management. In order to support such IRQ chips, add a poin

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-19 Thread Thomas Gleixner
On Thu, 17 Mar 2016, Jon Hunter wrote: > /** > * struct irq_chip - hardware interrupt chip descriptor > * > + * @parent: pointer to associated device That's really a bad name. parent suggests that this is a parent interrupt chip and your explanation sucks as well. What's an associate

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-19 Thread Grygorii Strashko
On 03/18/2016 02:27 PM, Jon Hunter wrote: > > On 18/03/16 11:11, Grygorii Strashko wrote: >> Hi Jon, >> >> On 03/17/2016 04:19 PM, Jon Hunter wrote: >>> Some IRQ chips may be located in a power domain outside of the CPU >>> subsystem and hence will require device specific runtime power >>> managem

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-19 Thread Marc Zyngier
Hi Jon, On 17/03/16 14:19, Jon Hunter wrote: > Some IRQ chips may be located in a power domain outside of the CPU > subsystem and hence will require device specific runtime power > management. In order to support such IRQ chips, add a pointer for a > device structure to the irq_chip structure, and

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-19 Thread Jon Hunter
On 17/03/16 15:02, Thomas Gleixner wrote: > On Thu, 17 Mar 2016, Jon Hunter wrote: >> /** >> * struct irq_chip - hardware interrupt chip descriptor >> * >> + * @parent: pointer to associated device > > That's really a bad name. parent suggests that this is a parent interrupt chip > a

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-19 Thread Grygorii Strashko
Hi Jon, On 03/17/2016 04:19 PM, Jon Hunter wrote: > Some IRQ chips may be located in a power domain outside of the CPU > subsystem and hence will require device specific runtime power > management. In order to support such IRQ chips, add a pointer for a > device structure to the irq_chip structure

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-19 Thread Jon Hunter
Hi Marc, On 17/03/16 15:02, Marc Zyngier wrote: > Hi Jon, > > On 17/03/16 14:19, Jon Hunter wrote: >> Some IRQ chips may be located in a power domain outside of the CPU >> subsystem and hence will require device specific runtime power >> management. In order to support such IRQ chips, add a point

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-19 Thread Jon Hunter
On 18/03/16 14:23, Grygorii Strashko wrote: > On 03/18/2016 02:27 PM, Jon Hunter wrote: >> >> On 18/03/16 11:11, Grygorii Strashko wrote: >>> Hi Jon, >>> >>> On 03/17/2016 04:19 PM, Jon Hunter wrote: Some IRQ chips may be located in a power domain outside of the CPU subsystem and hence w

Re: [PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-19 Thread Marc Zyngier
On 17/03/16 15:13, Jon Hunter wrote: > Hi Marc, > > On 17/03/16 15:02, Marc Zyngier wrote: >> Hi Jon, >> >> On 17/03/16 14:19, Jon Hunter wrote: >>> Some IRQ chips may be located in a power domain outside of the CPU >>> subsystem and hence will require device specific runtime power >>> management.

[PATCH 08/15] genirq: Add runtime power management support for IRQ chips

2016-03-18 Thread Jon Hunter
Some IRQ chips may be located in a power domain outside of the CPU subsystem and hence will require device specific runtime power management. In order to support such IRQ chips, add a pointer for a device structure to the irq_chip structure, and if this pointer is populated by the IRQ chip driver a