Re: [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-10-14 Thread Dave Stevenson
Hi André On Sat, 12 Oct 2024 at 22:46, André Apitzsch wrote: > > Hi Dave, > > Am Montag, dem 07.10.2024 um 18:29 +0100 schrieb Dave Stevenson: > > Hi Andre > > > > On Sun, 6 Oct 2024 at 22:41, André wrote: > > > > > > Hi Dave, > > > > > > Am Freitag, dem 13.09.2024 um 18:40 +0100 schrieb Dave St

Re: [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-10-12 Thread André Apitzsch
Hi Dave, Am Montag, dem 07.10.2024 um 18:29 +0100 schrieb Dave Stevenson: > Hi Andre > > On Sun, 6 Oct 2024 at 22:41, André wrote: > > > > Hi Dave, > > > > Am Freitag, dem 13.09.2024 um 18:40 +0100 schrieb Dave Stevenson: > > > On Thu, 12 Sept 2024 at 15:51, Dave Stevenson > > > wrote: > > >

Re: [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-10-07 Thread Dave Stevenson
Hi Andre On Sun, 6 Oct 2024 at 22:41, André wrote: > > Hi Dave, > > Am Freitag, dem 13.09.2024 um 18:40 +0100 schrieb Dave Stevenson: > > On Thu, 12 Sept 2024 at 15:51, Dave Stevenson > > wrote: > > > > > > Hi André & Ricardo > > > > > > On Thu, 12 Sept 2024 at 14:41, Ricardo Ribalda Delgado > >

Re: [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-10-06 Thread André
Hi Dave, Am Freitag, dem 13.09.2024 um 18:40 +0100 schrieb Dave Stevenson: > On Thu, 12 Sept 2024 at 15:51, Dave Stevenson > wrote: > > > > Hi André & Ricardo > > > > On Thu, 12 Sept 2024 at 14:41, Ricardo Ribalda Delgado > > wrote: > > > > > > Hi > > > > > > Arent you missing some chage in

Re: [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-09-13 Thread Dave Stevenson
On Thu, 12 Sept 2024 at 15:51, Dave Stevenson wrote: > > Hi André & Ricardo > > On Thu, 12 Sept 2024 at 14:41, Ricardo Ribalda Delgado > wrote: > > > > Hi > > > > Arent you missing some chage in enum_frame_interval? > > Raw sensors shouldn't be using [enum|set|get]_frame_interval at all > https:/

Re: [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-09-12 Thread Dave Stevenson
Hi André & Ricardo On Thu, 12 Sept 2024 at 14:41, Ricardo Ribalda Delgado wrote: > > Hi > > Arent you missing some chage in enum_frame_interval? Raw sensors shouldn't be using [enum|set|get]_frame_interval at all https://www.kernel.org/doc/html/latest/userspace-api/media/drivers/camera-sensor.ht

Re: [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-09-12 Thread Ricardo Ribalda Delgado
Hi Arent you missing some chage in enum_frame_interval? On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay wrote: > > From: André Apitzsch > > Add vblank control to allow changing the framerate / > higher exposure values. > > The vblank and hblank controls are needed for libcamera supp

[PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch Add vblank control to allow changing the framerate / higher exposure values. The vblank and hblank controls are needed for libcamera support. While at it, fix the minimal exposure time according to the datasheet. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214