Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-18 Thread Lee Jones
> >> diff --git a/drivers/input/keyboard/cros_ec_keyb.c > >> b/drivers/input/keyboard/cros_ec_keyb.c > >> index 4083796..dc37b6b 100644 > >> --- a/drivers/input/keyboard/cros_ec_keyb.c > >> +++ b/drivers/input/keyboard/cros_ec_keyb.c > >> @@ -191,8 +191,18 @@ static void cros_ec_keyb_close(struct

Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-17 Thread Simon Glass
Hi Doug, On 17 June 2014 21:27, Doug Anderson wrote: > Simon, > > On Tue, Jun 17, 2014 at 8:42 PM, Simon Glass wrote: >>> diff --git a/drivers/input/keyboard/cros_ec_keyb.c >>> b/drivers/input/keyboard/cros_ec_keyb.c >>> index 4083796..dc37b6b 100644 >>> --- a/drivers/input/keyboard/cros_ec_key

Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-17 Thread Doug Anderson
Simon, On Tue, Jun 17, 2014 at 8:42 PM, Simon Glass wrote: >> diff --git a/drivers/input/keyboard/cros_ec_keyb.c >> b/drivers/input/keyboard/cros_ec_keyb.c >> index 4083796..dc37b6b 100644 >> --- a/drivers/input/keyboard/cros_ec_keyb.c >> +++ b/drivers/input/keyboard/cros_ec_keyb.c >> @@ -191,8

Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson wrote: > From: Bill Richardson > > Remove the three wrapper functions that talk to the EC without passing all > the desired arguments and just use the underlying communication function > that passes everything in a struct intead. > > This is internal

[PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-16 Thread Doug Anderson
From: Bill Richardson Remove the three wrapper functions that talk to the EC without passing all the desired arguments and just use the underlying communication function that passes everything in a struct intead. This is internal code refactoring only. Nothing should change. Signed-off-by: Bill