Re: [PATCH 076/196] ecryptfs: remove version_str file from sysfs

2008-01-25 Thread Jeff Garzik
Michael Halcrow wrote: On Fri, Jan 25, 2008 at 09:54:21AM -0800, Greg KH wrote: I could not find any userspace tools or documentation that used it The version_str handle is only there as a potential convenience for users who need to figure out what their module can and cannot do. I mentioned i

Re: [PATCH 076/196] ecryptfs: remove version_str file from sysfs

2008-01-25 Thread Michael Halcrow
On Fri, Jan 25, 2008 at 09:54:21AM -0800, Greg KH wrote: > I could not find any userspace tools or documentation that used it The version_str handle is only there as a potential convenience for users who need to figure out what their module can and cannot do. I mentioned it in an article in LJ las

Re: [PATCH 076/196] ecryptfs: remove version_str file from sysfs

2008-01-25 Thread Greg KH
On Fri, Jan 25, 2008 at 03:25:22AM -0500, Jeff Garzik wrote: > Greg Kroah-Hartman wrote: >> This file violates the one-value-per-file sysfs rule. >> If you all want it added back, please do something like a per-feature >> file to show what is present and what isn't. >> Cc: Kay Sievers <[EMAIL PROTE

Re: [PATCH 076/196] ecryptfs: remove version_str file from sysfs

2008-01-25 Thread Jeff Garzik
Greg Kroah-Hartman wrote: This file violates the one-value-per-file sysfs rule. If you all want it added back, please do something like a per-feature file to show what is present and what isn't. Cc: Kay Sievers <[EMAIL PROTECTED]> Cc: Mike Halcrow <[EMAIL PROTECTED]> Cc: Phillip Hellewell <[EMA

[PATCH 076/196] ecryptfs: remove version_str file from sysfs

2008-01-25 Thread Greg Kroah-Hartman
This file violates the one-value-per-file sysfs rule. If you all want it added back, please do something like a per-feature file to show what is present and what isn't. Cc: Kay Sievers <[EMAIL PROTECTED]> Cc: Mike Halcrow <[EMAIL PROTECTED]> Cc: Phillip Hellewell <[EMAIL PROTECTED]> Signed-off-by