Re: [PATCH 07/50] mm: Account for a THP NUMA hinting update as one PTE update

2013-09-16 Thread Peter Zijlstra
On Mon, Sep 16, 2013 at 05:11:50PM +0100, Mel Gorman wrote: > > I never said the change didn't make sense as such. Just that we're no > > longer counting pages in change_*_range(). > > well, it's still a THP page. Is it worth renaming? Dunno, the pedant in me needed to raise the issue :-) -- To u

Re: [PATCH 07/50] mm: Account for a THP NUMA hinting update as one PTE update

2013-09-16 Thread Mel Gorman
On Mon, Sep 16, 2013 at 04:54:38PM +0200, Peter Zijlstra wrote: > On Mon, Sep 16, 2013 at 09:39:59AM -0400, Rik van Riel wrote: > > On 09/16/2013 08:36 AM, Peter Zijlstra wrote: > > > On Tue, Sep 10, 2013 at 10:31:47AM +0100, Mel Gorman wrote: > > >> A THP PMD update is accounted for as 512 pages u

Re: [PATCH 07/50] mm: Account for a THP NUMA hinting update as one PTE update

2013-09-16 Thread Peter Zijlstra
On Mon, Sep 16, 2013 at 09:39:59AM -0400, Rik van Riel wrote: > On 09/16/2013 08:36 AM, Peter Zijlstra wrote: > > On Tue, Sep 10, 2013 at 10:31:47AM +0100, Mel Gorman wrote: > >> A THP PMD update is accounted for as 512 pages updated in vmstat. This is > >> large difference when estimating the cos

Re: [PATCH 07/50] mm: Account for a THP NUMA hinting update as one PTE update

2013-09-16 Thread Rik van Riel
On 09/16/2013 08:36 AM, Peter Zijlstra wrote: > On Tue, Sep 10, 2013 at 10:31:47AM +0100, Mel Gorman wrote: >> A THP PMD update is accounted for as 512 pages updated in vmstat. This is >> large difference when estimating the cost of automatic NUMA balancing and >> can be misleading when comparing

Re: [PATCH 07/50] mm: Account for a THP NUMA hinting update as one PTE update

2013-09-16 Thread Peter Zijlstra
On Tue, Sep 10, 2013 at 10:31:47AM +0100, Mel Gorman wrote: > A THP PMD update is accounted for as 512 pages updated in vmstat. This is > large difference when estimating the cost of automatic NUMA balancing and > can be misleading when comparing results that had collapsed versus split > THP. This

[PATCH 07/50] mm: Account for a THP NUMA hinting update as one PTE update

2013-09-10 Thread Mel Gorman
A THP PMD update is accounted for as 512 pages updated in vmstat. This is large difference when estimating the cost of automatic NUMA balancing and can be misleading when comparing results that had collapsed versus split THP. This patch addresses the accounting issue. Signed-off-by: Mel Gorman -