Re: [PATCH 07/19] x86/dumpstack: add IRQ_USABLE_STACK_SIZE define

2016-07-22 Thread Ingo Molnar
* Josh Poimboeuf wrote: > > > irq_stack_end = (unsigned long *)(per_cpu(irq_stack_ptr, cpu)); > > > - irq_stack = (unsigned long *)(per_cpu(irq_stack_ptr, cpu) - > > > IRQ_STACK_SIZE); > > > + irq_stack = (unsigned long *)(per_cpu(irq_stack_ptr, cpu) - > > > +

Re: [PATCH 07/19] x86/dumpstack: add IRQ_USABLE_STACK_SIZE define

2016-07-21 Thread Josh Poimboeuf
On Thu, Jul 21, 2016 at 03:01:10PM -0700, Andy Lutomirski wrote: > On Thu, Jul 21, 2016 at 2:21 PM, Josh Poimboeuf wrote: > > For reasons unknown, the x86_64 irq stack starts at an offset 64 bytes > > from the end of the page. At least make that explicit. > > This is a change in behavior -- see

Re: [PATCH 07/19] x86/dumpstack: add IRQ_USABLE_STACK_SIZE define

2016-07-21 Thread Andy Lutomirski
On Thu, Jul 21, 2016 at 2:21 PM, Josh Poimboeuf wrote: > For reasons unknown, the x86_64 irq stack starts at an offset 64 bytes > from the end of the page. At least make that explicit. This is a change in behavior -- see below. Please mention this in the changelog. > > FIXME: Can we just remov

[PATCH 07/19] x86/dumpstack: add IRQ_USABLE_STACK_SIZE define

2016-07-21 Thread Josh Poimboeuf
For reasons unknown, the x86_64 irq stack starts at an offset 64 bytes from the end of the page. At least make that explicit. FIXME: Can we just remove the 64 byte gap? If not, at least document why. Signed-off-by: Josh Poimboeuf --- arch/x86/include/asm/page_64_types.h | 19 +++--