Re: [PATCH 07/15] tty: serial: 8250_dma: enqueue RX dma again on completion.

2014-08-29 Thread Sebastian Andrzej Siewior
On 08/18/2014 12:52 PM, One Thousand Gnomes wrote: > >> if (!up->dma || dma_err) >> status = serial8250_rx_chars(up, status); >> + >> +if (dma_err && port->type == PORT_OMAP_16750) >> +serial8250_rx_dma(up, 0); > > Can we stick to

Re: [PATCH 07/15] tty: serial: 8250_dma: enqueue RX dma again on completion.

2014-08-18 Thread One Thousand Gnomes
> if (!up->dma || dma_err) > status = serial8250_rx_chars(up, status); > + > + if (dma_err && port->type == PORT_OMAP_16750) > + serial8250_rx_dma(up, 0); Can we stick to a 'has dma' flag and port->rx_dma() type usages so that we

[PATCH 07/15] tty: serial: 8250_dma: enqueue RX dma again on completion.

2014-08-15 Thread Sebastian Andrzej Siewior
The omap needs a DMA request pending right away. If it is enqueued once the bytes are in the FIFO then nothing will happen and the FIFO will be later purged via RX-timeout interrupt. This patch enqueues RX-DMA request on completion but not if it was aborted on error. The first enqueue will happen i