Re: [PATCH 07/13] tracing/kdb: remove redundant checking

2013-03-11 Thread Jovi Zhang
On Mon, Mar 11, 2013 at 10:46 PM, Jason Wessel wrote: > On 03/11/2013 09:09 AM, Steven Rostedt wrote: >> This is Jason's code. >> >> Jason, please give an Ack or Nack. >> >> Thanks, >> >> -- Steve >> >> >> On Mon, 2013-03-11 at 15:13 +0800, zhangwei(Jovi) wrote: >>> trace_empty is checking in whil

Re: [PATCH 07/13] tracing/kdb: remove redundant checking

2013-03-11 Thread Jason Wessel
On 03/11/2013 09:09 AM, Steven Rostedt wrote: > This is Jason's code. > > Jason, please give an Ack or Nack. > > Thanks, > > -- Steve > > > On Mon, 2013-03-11 at 15:13 +0800, zhangwei(Jovi) wrote: >> trace_empty is checking in while-loop, so the previous checking >> is totally redundant, and more w

Re: [PATCH 07/13] tracing/kdb: remove redundant checking

2013-03-11 Thread Steven Rostedt
This is Jason's code. Jason, please give an Ack or Nack. Thanks, -- Steve On Mon, 2013-03-11 at 15:13 +0800, zhangwei(Jovi) wrote: > trace_empty is checking in while-loop, so the previous checking > is totally redundant, and more worse, the first trace entry is losted. > > so remove it. > >

[PATCH 07/13] tracing/kdb: remove redundant checking

2013-03-11 Thread zhangwei(Jovi)
trace_empty is checking in while-loop, so the previous checking is totally redundant, and more worse, the first trace entry is losted. so remove it. Signed-off-by: zhangwei(Jovi) --- kernel/trace/trace_kdb.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/trace/t