Re: [PATCH 07/12] PM / OPP: Update OPP users to put reference

2017-01-20 Thread Chanwoo Choi
Hi Viresh, For devfreq part, Looks good to me. Reviewed-by: Chanwoo Choi 2016-12-08 13:00 GMT+09:00 Viresh Kumar : > On 07-12-16, 22:23, Chanwoo Choi wrote: >> I think that the dev_pm_opp_put(opp) should be called after if statement >> If dev_pm_opp_find_freq_ceil() return error, I think the c

Re: [PATCH 07/12] PM / OPP: Update OPP users to put reference

2016-12-07 Thread Viresh Kumar
On 07-12-16, 22:23, Chanwoo Choi wrote: > I think that the dev_pm_opp_put(opp) should be called after if statement > If dev_pm_opp_find_freq_ceil() return error, I think the calling of > dev_pm_opp_put(opp) is not necessary. During development I had following check in dev_pm_opp_put(): if

Re: [PATCH 07/12] PM / OPP: Update OPP users to put reference

2016-12-07 Thread Chanwoo Choi
Hi Viresh, [snip] > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index b0de42972b74..89add0d7c017 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -111,18 +111,16 @@ static void devfreq_set_freq_table(struct devfreq > *devfreq) >

[PATCH 07/12] PM / OPP: Update OPP users to put reference

2016-12-07 Thread Viresh Kumar
This patch updates dev_pm_opp_find_freq_*() routines to get a reference to the OPPs returned by them. Also updates the users of dev_pm_opp_find_freq_*() routines to call dev_pm_opp_put() after they are done using the OPPs. As it is guaranteed the that OPPs wouldn't get freed while being used, the