Re: [PATCH 07/11] x86/fault: Split the OOPS code out from no_context()

2021-02-09 Thread Andy Lutomirski
On Wed, Feb 3, 2021 at 10:56 AM Borislav Petkov wrote: > > On Sun, Jan 31, 2021 at 09:24:38AM -0800, Andy Lutomirski wrote: > > Not all callers of no_context() want to run exception fixups. > > Separate the OOPS code out from the fixup code in no_context(). > > > > Cc: Dave Hansen > > Cc: Peter Z

Re: [PATCH 07/11] x86/fault: Split the OOPS code out from no_context()

2021-02-03 Thread Borislav Petkov
On Wed, Feb 03, 2021 at 11:29:39AM -0800, Andy Lutomirski wrote: > That function is a lie. It tries to keep the system alive but it > doesn’t return if it “recovers”. Maybe I should add a comment? ... or rename it? That schedule() at the end, I dunno if that does anything since we're going to oop

Re: [PATCH 07/11] x86/fault: Split the OOPS code out from no_context()

2021-02-03 Thread Andy Lutomirski
> On Feb 3, 2021, at 10:56 AM, Borislav Petkov wrote: > > On Sun, Jan 31, 2021 at 09:24:38AM -0800, Andy Lutomirski wrote: >> Not all callers of no_context() want to run exception fixups. >> Separate the OOPS code out from the fixup code in no_context(). >> >> Cc: Dave Hansen >> Cc: Peter Z

Re: [PATCH 07/11] x86/fault: Split the OOPS code out from no_context()

2021-02-03 Thread Borislav Petkov
On Sun, Jan 31, 2021 at 09:24:38AM -0800, Andy Lutomirski wrote: > Not all callers of no_context() want to run exception fixups. > Separate the OOPS code out from the fixup code in no_context(). > > Cc: Dave Hansen > Cc: Peter Zijlstra > Signed-off-by: Andy Lutomirski > --- > arch/x86/mm/fault

[PATCH 07/11] x86/fault: Split the OOPS code out from no_context()

2021-01-31 Thread Andy Lutomirski
Not all callers of no_context() want to run exception fixups. Separate the OOPS code out from the fixup code in no_context(). Cc: Dave Hansen Cc: Peter Zijlstra Signed-off-by: Andy Lutomirski --- arch/x86/mm/fault.c | 116 +++- 1 file changed, 62 inserti