Re: [PATCH 07/11] mm: VM_BUG_ON lru page flags

2020-12-15 Thread Matthew Wilcox
On Tue, Dec 15, 2020 at 05:54:51PM -0700, Yu Zhao wrote: > On Mon, Dec 07, 2020 at 10:24:29PM +, Matthew Wilcox wrote: > > On Mon, Dec 07, 2020 at 03:09:45PM -0700, Yu Zhao wrote: > > > Move scattered VM_BUG_ONs to two essential places that cover all > > > lru list additions and deletions. > >

Re: [PATCH 07/11] mm: VM_BUG_ON lru page flags

2020-12-15 Thread Yu Zhao
On Mon, Dec 07, 2020 at 10:24:29PM +, Matthew Wilcox wrote: > On Mon, Dec 07, 2020 at 03:09:45PM -0700, Yu Zhao wrote: > > Move scattered VM_BUG_ONs to two essential places that cover all > > lru list additions and deletions. > > I'd like to see these converted into VM_BUG_ON_PGFLAGS so you ha

Re: [PATCH 07/11] mm: VM_BUG_ON lru page flags

2020-12-07 Thread Matthew Wilcox
On Mon, Dec 07, 2020 at 03:09:45PM -0700, Yu Zhao wrote: > Move scattered VM_BUG_ONs to two essential places that cover all > lru list additions and deletions. I'd like to see these converted into VM_BUG_ON_PGFLAGS so you have to take that extra CONFIG step to enable checking them.

[PATCH 07/11] mm: VM_BUG_ON lru page flags

2020-12-07 Thread Yu Zhao
Move scattered VM_BUG_ONs to two essential places that cover all lru list additions and deletions. Signed-off-by: Yu Zhao --- include/linux/mm_inline.h | 4 mm/swap.c | 2 -- mm/vmscan.c | 1 - 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/incl