Re: [PATCH 07/11] igb: Avoid uninitialized advertised variable in eee_set_cur

2013-10-02 Thread David Miller
From: Andi Kleen Date: Mon, 30 Sep 2013 13:29:08 -0700 > From: Andi Kleen > > eee_get_cur assumes that the output data is already zeroed. It can > read-modify-write the advertised field: > > if (ipcnfg & E1000_IPCNFG_EEE_100M_AN) > 2594 edata->advertised |= ADVER

Re: [PATCH 07/11] igb: Avoid uninitialized advertised variable in eee_set_cur

2013-10-01 Thread Jeff Kirsher
On Mon, 2013-09-30 at 13:29 -0700, Andi Kleen wrote: > From: Andi Kleen > > eee_get_cur assumes that the output data is already zeroed. It can > read-modify-write the advertised field: > > if (ipcnfg & E1000_IPCNFG_EEE_100M_AN) > 2594edata->advertised |= ADVERTI

RE: [PATCH 07/11] igb: Avoid uninitialized advertised variable in eee_set_cur

2013-10-01 Thread Wyborny, Carolyn
ct: [PATCH 07/11] igb: Avoid uninitialized advertised variable in > eee_set_cur > > From: Andi Kleen > > eee_get_cur assumes that the output data is already zeroed. It can > read-modify- > write the advertised field: > > if (ipcnfg & E1000_IPCNFG_EE

[PATCH 07/11] igb: Avoid uninitialized advertised variable in eee_set_cur

2013-09-30 Thread Andi Kleen
From: Andi Kleen eee_get_cur assumes that the output data is already zeroed. It can read-modify-write the advertised field: if (ipcnfg & E1000_IPCNFG_EEE_100M_AN) 2594edata->advertised |= ADVERTISED_100baseT_Full; This is ok for the normal ethtool eee_get call,