Re: [PATCH 07/11] btrfs: move to fn pointers for get/put workspaces

2019-01-29 Thread Dennis Zhou
Hi Nikolay, On Tue, Jan 29, 2019 at 10:22:34AM +0200, Nikolay Borisov wrote: > > > On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > > The previous patch added generic helpers for get_workspace() and > > put_workspace(). Now, we can migrate ownership of the workspace_manager > > to be in the compres

Re: [PATCH 07/11] btrfs: move to fn pointers for get/put workspaces

2019-01-29 Thread Josef Bacik
On Tue, Jan 29, 2019 at 01:17:17PM -0500, Josef Bacik wrote: > On Mon, Jan 28, 2019 at 04:24:33PM -0500, Dennis Zhou wrote: > > The previous patch added generic helpers for get_workspace() and > > put_workspace(). Now, we can migrate ownership of the workspace_manager > > to be in the compression t

Re: [PATCH 07/11] btrfs: move to fn pointers for get/put workspaces

2019-01-29 Thread Josef Bacik
On Mon, Jan 28, 2019 at 04:24:33PM -0500, Dennis Zhou wrote: > The previous patch added generic helpers for get_workspace() and > put_workspace(). Now, we can migrate ownership of the workspace_manager > to be in the compression type code as the compression code itself > doesn't care beyond being a

Re: [PATCH 07/11] btrfs: move to fn pointers for get/put workspaces

2019-01-29 Thread Nikolay Borisov
On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > The previous patch added generic helpers for get_workspace() and > put_workspace(). Now, we can migrate ownership of the workspace_manager > to be in the compression type code as the compression code itself > doesn't care beyond being able to get a w

[PATCH 07/11] btrfs: move to fn pointers for get/put workspaces

2019-01-28 Thread Dennis Zhou
The previous patch added generic helpers for get_workspace() and put_workspace(). Now, we can migrate ownership of the workspace_manager to be in the compression type code as the compression code itself doesn't care beyond being able to get a workspace. The init/cleanup and get/put methods are abst