Re: [PATCH 06/15] tty: serial: 8250_dma: handle error on TX submit

2014-09-01 Thread Sebastian Andrzej Siewior
On 08/18/2014 03:57 PM, Heikki Krogerus wrote: > On Fri, Aug 15, 2014 at 07:42:34PM +0200, Sebastian Andrzej Siewior wrote: >> diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h >> index b161eee..02e82dc 100644 >> --- a/include/linux/serial_8250.h >> +++ b/include/linux/serial_8

Re: [PATCH 06/15] tty: serial: 8250_dma: handle error on TX submit

2014-08-18 Thread Heikki Krogerus
On Fri, Aug 15, 2014 at 07:42:34PM +0200, Sebastian Andrzej Siewior wrote: > diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h > index b161eee..02e82dc 100644 > --- a/include/linux/serial_8250.h > +++ b/include/linux/serial_8250.h > @@ -85,6 +85,7 @@ struct uart_8250_port { >

[PATCH 06/15] tty: serial: 8250_dma: handle error on TX submit

2014-08-15 Thread Sebastian Andrzej Siewior
Right now it is possible that serial8250_tx_dma() fails and returns -EBUSY. The caller (serial8250_start_tx()) will then enable UART_IER_THRI which will generate an interrupt once the TX FIFO is empty. In serial8250_handle_irq() nothing will happen because up->dma is set and so serial8250_tx_chars(