Re: [PATCH 06/14] fs: remove the call_{read,write}_iter functions

2020-05-28 Thread Christoph Hellwig
On Thu, May 28, 2020 at 07:56:43PM +0100, Al Viro wrote: > On Thu, May 28, 2020 at 07:40:35AM +0200, Christoph Hellwig wrote: > > Just open coding the methods calls is a lot easier to follow. > > Not sure about this one, TBH - it's harder to grep that way, since > you get all the initializers for

Re: [PATCH 06/14] fs: remove the call_{read,write}_iter functions

2020-05-28 Thread Al Viro
On Thu, May 28, 2020 at 07:40:35AM +0200, Christoph Hellwig wrote: > Just open coding the methods calls is a lot easier to follow. Not sure about this one, TBH - it's harder to grep that way, since you get all the initializers for read_iter/write_iter thrown into the mix. Sure, you can do somethi

[PATCH 06/14] fs: remove the call_{read,write}_iter functions

2020-05-27 Thread Christoph Hellwig
Just open coding the methods calls is a lot easier to follow. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 4 ++-- drivers/target/target_core_file.c | 4 ++-- fs/aio.c | 4 ++-- fs/io_uring.c | 4 ++-- fs/read_write.c

[PATCH 06/14] fs: remove the call_{read,write}_iter functions

2020-05-12 Thread Christoph Hellwig
Just open coding the methods calls is a lot easier to follow. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 4 ++-- drivers/target/target_core_file.c | 4 ++-- fs/aio.c | 4 ++-- fs/io_uring.c | 4 ++-- fs/read_write.c