Re: [PATCH 06/11] compat_ioctl: remove /dev/random commands

2018-09-13 Thread Arnd Bergmann
On Thu, Sep 13, 2018 at 8:42 AM Martin Schwidefsky wrote: > > On Wed, 12 Sep 2018 16:02:40 +0200 > Arnd Bergmann wrote: > > > On Wed, Sep 12, 2018 at 7:29 AM Martin Schwidefsky > > wrote: > > > On Tue, 11 Sep 2018 22:26:54 +0200 Arnd Bergmann wrote: > > > > This should probably be separate fro

Re: [PATCH 06/11] compat_ioctl: remove /dev/random commands

2018-09-12 Thread Martin Schwidefsky
On Wed, 12 Sep 2018 16:02:40 +0200 Arnd Bergmann wrote: > On Wed, Sep 12, 2018 at 7:29 AM Martin Schwidefsky > wrote: > > On Tue, 11 Sep 2018 22:26:54 +0200 Arnd Bergmann wrote: > > > On Sun, Sep 9, 2018 at 6:12 AM Al Viro wrote: > > > > Out of those, there are only a few that may get use

Re: [PATCH 06/11] compat_ioctl: remove /dev/random commands

2018-09-12 Thread Arnd Bergmann
On Wed, Sep 12, 2018 at 7:29 AM Martin Schwidefsky wrote: > On Tue, 11 Sep 2018 22:26:54 +0200 Arnd Bergmann wrote: > > On Sun, Sep 9, 2018 at 6:12 AM Al Viro wrote: > > Out of those, there are only a few that may get used on s390, > > in particular at most infiniband/uverbs, nvme, nvdimm, > >

Re: [PATCH 06/11] compat_ioctl: remove /dev/random commands

2018-09-11 Thread Martin Schwidefsky
On Tue, 11 Sep 2018 22:26:54 +0200 Arnd Bergmann wrote: > On Sun, Sep 9, 2018 at 6:12 AM Al Viro wrote: > > > > On Sat, Sep 08, 2018 at 04:28:12PM +0200, Arnd Bergmann wrote: > > > These are all handled by the random driver, so instead of listing > > > each ioctl, we can just use the same func

Re: [PATCH 06/11] compat_ioctl: remove /dev/random commands

2018-09-11 Thread Arnd Bergmann
On Sun, Sep 9, 2018 at 6:12 AM Al Viro wrote: > > On Sat, Sep 08, 2018 at 04:28:12PM +0200, Arnd Bergmann wrote: > > These are all handled by the random driver, so instead of listing > > each ioctl, we can just use the same function to deal with both > > native and compat commands. > > Umm... I d

Re: [PATCH 06/11] compat_ioctl: remove /dev/random commands

2018-09-08 Thread Al Viro
On Sat, Sep 08, 2018 at 04:28:12PM +0200, Arnd Bergmann wrote: > These are all handled by the random driver, so instead of listing > each ioctl, we can just use the same function to deal with both > native and compat commands. Umm... I don't think it's right - > .unlocked_ioctl = random_io

[PATCH 06/11] compat_ioctl: remove /dev/random commands

2018-09-08 Thread Arnd Bergmann
These are all handled by the random driver, so instead of listing each ioctl, we can just use the same function to deal with both native and compat commands. Signed-off-by: Arnd Bergmann --- drivers/char/random.c | 1 + fs/compat_ioctl.c | 7 --- 2 files changed, 1 insertion(+), 7 deleti