Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

2018-01-16 Thread Liuwenliang (Abbott Liu)
On 6 December 2017 at 1:09 Ard Biesheuvel [ard.biesheu...@linaro.org] wrote: >On 5 December 2017 at 14:19, Liuwenliang (Abbott Liu) > wrote: >> On Nov 23, 2017 20:30 Russell King - ARM Linux >> [mailto:li...@armlinux.org.uk] wrote: >>>On Thu, Oct 12, 2017 at 11:27:40AM +, Liuwenliang (Lamb

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

2017-12-05 Thread Ard Biesheuvel
On 5 December 2017 at 14:19, Liuwenliang (Abbott Liu) wrote: > On Nov 23, 2017 20:30 Russell King - ARM Linux > [mailto:li...@armlinux.org.uk] wrote: >>On Thu, Oct 12, 2017 at 11:27:40AM +, Liuwenliang (Lamb) wrote: >>> >> - I don't understand why this is necessary. memory_is_poisoned_16(

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

2017-12-05 Thread Liuwenliang (Abbott Liu)
On Nov 23, 2017 20:30 Russell King - ARM Linux [mailto:li...@armlinux.org.uk] wrote: >On Thu, Oct 12, 2017 at 11:27:40AM +, Liuwenliang (Lamb) wrote: >> >> - I don't understand why this is necessary. memory_is_poisoned_16() >> >> already handles unaligned addresses? >> >> >> >> - If it's

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

2017-10-19 Thread Russell King - ARM Linux
On Thu, Oct 12, 2017 at 11:27:40AM +, Liuwenliang (Lamb) wrote: > >> - I don't understand why this is necessary. memory_is_poisoned_16() > >> already handles unaligned addresses? > >> > >> - If it's needed on ARM then presumably it will be needed on other > >> architectures, so CONFIG_ARM

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

2017-10-12 Thread Liuwenliang (Lamb)
>> - I don't understand why this is necessary. memory_is_poisoned_16() >> already handles unaligned addresses? >> >> - If it's needed on ARM then presumably it will be needed on other >> architectures, so CONFIG_ARM is insufficiently general. >> >> - If the present memory_is_poisoned_16() inde

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

2017-10-12 Thread Dmitry Vyukov
On Thu, Oct 12, 2017 at 1:23 AM, Andrew Morton wrote: > On Wed, 11 Oct 2017 16:22:22 +0800 Abbott Liu wrote: > >> Because arm instruction set don't support access the address which is >> not aligned, so must change memory_is_poisoned_16 for arm. >> >> ... >> >> --- a/mm/kasan/kasan.c >> +++ b/m

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

2017-10-11 Thread Andrew Morton
On Wed, 11 Oct 2017 16:22:22 +0800 Abbott Liu wrote: > Because arm instruction set don't support access the address which is > not aligned, so must change memory_is_poisoned_16 for arm. > > ... > > --- a/mm/kasan/kasan.c > +++ b/mm/kasan/kasan.c > @@ -149,6 +149,25 @@ static __always_inline bo

[PATCH 06/11] change memory_is_poisoned_16 for aligned error

2017-10-11 Thread Abbott Liu
Because arm instruction set don't support access the address which is not aligned, so must change memory_is_poisoned_16 for arm. Cc: Andrey Ryabinin Signed-off-by: Abbott Liu --- mm/kasan/kasan.c | 20 1 file changed, 20 insertions(+) diff --git a/mm/kasan/kasan.c b/mm/