Re: [PATCH 05/16] slab: remove cachep in struct slab_rcu

2013-09-11 Thread Christoph Lameter
On Thu, 22 Aug 2013, Joonsoo Kim wrote: > We can get cachep using page in struct slab_rcu, so remove it. Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH 05/16] slab: remove cachep in struct slab_rcu

2013-08-23 Thread JoonSoo Kim
2013/8/24 Christoph Lameter : > On Fri, 23 Aug 2013, JoonSoo Kim wrote: > >> I don't get it. This patch only affect to the rcu case, because it >> change the code >> which is in kmem_rcu_free(). It doesn't touch anything in standard case. > > In general this patchset moves struct slab to overlay st

Re: [PATCH 05/16] slab: remove cachep in struct slab_rcu

2013-08-23 Thread Christoph Lameter
On Fri, 23 Aug 2013, JoonSoo Kim wrote: > I don't get it. This patch only affect to the rcu case, because it > change the code > which is in kmem_rcu_free(). It doesn't touch anything in standard case. In general this patchset moves struct slab to overlay struct page. The design of SLAB was (at l

Re: [PATCH 05/16] slab: remove cachep in struct slab_rcu

2013-08-23 Thread JoonSoo Kim
2013/8/23 Christoph Lameter : > On Fri, 23 Aug 2013, Joonsoo Kim wrote: > >> On Thu, Aug 22, 2013 at 05:53:00PM +, Christoph Lameter wrote: >> > On Thu, 22 Aug 2013, Joonsoo Kim wrote: >> > >> > > We can get cachep using page in struct slab_rcu, so remove it. >> > >> > Ok but this means that we

Re: [PATCH 05/16] slab: remove cachep in struct slab_rcu

2013-08-23 Thread Christoph Lameter
On Fri, 23 Aug 2013, Joonsoo Kim wrote: > On Thu, Aug 22, 2013 at 05:53:00PM +, Christoph Lameter wrote: > > On Thu, 22 Aug 2013, Joonsoo Kim wrote: > > > > > We can get cachep using page in struct slab_rcu, so remove it. > > > > Ok but this means that we need to touch struct page. Additional

Re: [PATCH 05/16] slab: remove cachep in struct slab_rcu

2013-08-22 Thread Joonsoo Kim
On Thu, Aug 22, 2013 at 05:53:00PM +, Christoph Lameter wrote: > On Thu, 22 Aug 2013, Joonsoo Kim wrote: > > > We can get cachep using page in struct slab_rcu, so remove it. > > Ok but this means that we need to touch struct page. Additional cacheline > in cache footprint. In following patch

Re: [PATCH 05/16] slab: remove cachep in struct slab_rcu

2013-08-22 Thread Christoph Lameter
On Thu, 22 Aug 2013, Joonsoo Kim wrote: > We can get cachep using page in struct slab_rcu, so remove it. Ok but this means that we need to touch struct page. Additional cacheline in cache footprint. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

[PATCH 05/16] slab: remove cachep in struct slab_rcu

2013-08-22 Thread Joonsoo Kim
We can get cachep using page in struct slab_rcu, so remove it. Signed-off-by: Joonsoo Kim diff --git a/mm/slab.c b/mm/slab.c index 69dc25a..b378f91 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -204,7 +204,6 @@ typedef unsigned int kmem_bufctl_t; */ struct slab_rcu { struct rcu_head head;