Re: [PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-11 Thread Martin Schwidefsky
On Wed, 10 Apr 2019 20:57:21 +0200 Arnd Bergmann wrote: > On Wed, Apr 10, 2019 at 5:59 PM Martin Schwidefsky > wrote: > > On Tue, 9 Apr 2019 11:54:30 +0200 Harald Freudenberger > > wrote: > > > On 08.04.19 23:26, Arnd Bergmann wrote: > > > > } > > > Thanks Arnd, but as Nathan

Re: [PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-10 Thread Arnd Bergmann
On Wed, Apr 10, 2019 at 5:59 PM Martin Schwidefsky wrote: > On Tue, 9 Apr 2019 11:54:30 +0200 Harald Freudenberger > wrote: > > On 08.04.19 23:26, Arnd Bergmann wrote: > > > } > > Thanks Arnd, but as Nathan already wrote, I'd prefer to have the > > variable initialized with 0 instead

Re: [PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-10 Thread Martin Schwidefsky
On Tue, 9 Apr 2019 11:54:30 +0200 Harald Freudenberger wrote: > On 08.04.19 23:26, Arnd Bergmann wrote: > > The 'func_code' variable gets printed in debug statements without > > a prior initialization in multiple functions, as reported when building > > with clang: > > > > drivers/s390/crypto/zcr

Re: [PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-09 Thread Arnd Bergmann
On Tue, Apr 9, 2019 at 11:54 AM Harald Freudenberger wrote: > On 08.04.19 23:26, Arnd Bergmann wrote: > Thanks Arnd, but as Nathan already wrote, I'd prefer to have the > variable initialized with 0 instead of -1. > If you agree with this, I'll rewrite the patch and apply it to our > internal git

Re: [PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-09 Thread Harald Freudenberger
On 08.04.19 23:26, Arnd Bergmann wrote: > The 'func_code' variable gets printed in debug statements without > a prior initialization in multiple functions, as reported when building > with clang: > > drivers/s390/crypto/zcrypt_api.c:659:6: warning: variable 'func_code' is used > uninitialized when

Re: [PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-08 Thread Nathan Chancellor
On Mon, Apr 08, 2019 at 11:26:18PM +0200, Arnd Bergmann wrote: > The 'func_code' variable gets printed in debug statements without > a prior initialization in multiple functions, as reported when building > with clang: > > drivers/s390/crypto/zcrypt_api.c:659:6: warning: variable 'func_code' is us

[PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-08 Thread Arnd Bergmann
The 'func_code' variable gets printed in debug statements without a prior initialization in multiple functions, as reported when building with clang: drivers/s390/crypto/zcrypt_api.c:659:6: warning: variable 'func_code' is used uninitialized whenever 'if' condition is true [-Wsometimes-unin