Re: [PATCH 05/10] mm, util: Use dup_user to duplicate user memory

2012-09-26 Thread Ezequiel Garcia
Andrew, On Wed, Sep 26, 2012 at 6:42 PM, Andrew Morton wrote: > On Tue, 25 Sep 2012 22:15:38 -0300 > Ezequiel Garcia wrote: > >> > This patch increases util.o's text size by 238 bytes. A larger kernel >> > with a worsened cache footprint. >> > >> > And we did this to get marginally improved tra

Re: [PATCH 05/10] mm, util: Use dup_user to duplicate user memory

2012-09-26 Thread Andrew Morton
On Tue, 25 Sep 2012 22:15:38 -0300 Ezequiel Garcia wrote: > > This patch increases util.o's text size by 238 bytes. A larger kernel > > with a worsened cache footprint. > > > > And we did this to get marginally improved tracing output? This sounds > > like a bad tradeoff to me. > > > > Mmm, th

Re: [PATCH 05/10] mm, util: Use dup_user to duplicate user memory

2012-09-25 Thread Ezequiel Garcia
Hi Andrew, On Tue, Sep 25, 2012 at 6:29 PM, Andrew Morton wrote: > On Sat, 8 Sep 2012 17:47:54 -0300 > Ezequiel Garcia wrote: > >> Previously the strndup_user allocation was being done through memdup_user, >> and the caller was wrongly traced as being strndup_user >> (the correct trace must rep

Re: [PATCH 05/10] mm, util: Use dup_user to duplicate user memory

2012-09-25 Thread Andrew Morton
On Sat, 8 Sep 2012 17:47:54 -0300 Ezequiel Garcia wrote: > Previously the strndup_user allocation was being done through memdup_user, > and the caller was wrongly traced as being strndup_user > (the correct trace must report the caller of strndup_user). > > This is a common problem: in order to

Re: [PATCH 05/10] mm, util: Use dup_user to duplicate user memory

2012-09-25 Thread Pekka Enberg
On Sat, Sep 8, 2012 at 11:47 PM, Ezequiel Garcia wrote: > Previously the strndup_user allocation was being done through memdup_user, > and the caller was wrongly traced as being strndup_user > (the correct trace must report the caller of strndup_user). > > This is a common problem: in order to get

[PATCH 05/10] mm, util: Use dup_user to duplicate user memory

2012-09-08 Thread Ezequiel Garcia
Previously the strndup_user allocation was being done through memdup_user, and the caller was wrongly traced as being strndup_user (the correct trace must report the caller of strndup_user). This is a common problem: in order to get accurate callsite tracing, a utils function can't allocate throug