Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-12-23 Thread Jacek Anaszewski
On 12/12/18 7:32 PM, Pavel Machek wrote: On Wed 2018-12-12 07:56:20, Rob Herring wrote: On Wed, Dec 12, 2018 at 3:59 AM Pavel Machek wrote: Hi! We would also probably need different DT properties for different types of devices, since e.g. for network case the network interface name would fi

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-12-21 Thread Linus Walleij
On Tue, Dec 11, 2018 at 6:27 PM Rob Herring wrote: > On Sat, Dec 1, 2018 at 3:17 PM Jacek Anaszewski > wrote: > > This is not true in case of associations where LED controller is > > an independent device, as in Pavel's example [0]. > > I'm not really following how the HDD example is different.

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-12-12 Thread Pavel Machek
On Wed 2018-12-12 07:56:20, Rob Herring wrote: > On Wed, Dec 12, 2018 at 3:59 AM Pavel Machek wrote: > > > > Hi! > > > > > > We would also probably need different DT properties for different > > > > types of devices, since e.g. for network case the network interface > > > > name would fit better f

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-12-12 Thread Rob Herring
On Wed, Dec 12, 2018 at 3:59 AM Pavel Machek wrote: > > Hi! > > > > We would also probably need different DT properties for different > > > types of devices, since e.g. for network case the network interface > > > name would fit better for the LED name, than the phy name, > > > and we would need t

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-12-12 Thread Pavel Machek
Hi! > > We would also probably need different DT properties for different > > types of devices, since e.g. for network case the network interface > > name would fit better for the LED name, than the phy name, > > and we would need to know what type of device name we're going > > to look for. > > >

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-12-11 Thread Pavel Machek
Hi! > > >> Basically every single device could have a LED associated with it > > >> ("activity"). Would doing it like this mean we'd have to modify every > > >> single driver to parse leds / led-names properties? > > > > > > Normally, that's how properties like this would work. A driver is also >

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-12-11 Thread Rob Herring
On Sat, Dec 1, 2018 at 3:17 PM Jacek Anaszewski wrote: > > On 11/30/2018 11:19 PM, Rob Herring wrote: > > On Fri, Nov 30, 2018 at 3:08 PM Pavel Machek wrote: > >> > >> Hi! > >> > Pavel gave following examples: > > eth0:green:link > adsl0:green:link > adsl0:red:error > >>>

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-12-01 Thread Jacek Anaszewski
On 11/30/2018 11:19 PM, Rob Herring wrote: > On Fri, Nov 30, 2018 at 3:08 PM Pavel Machek wrote: >> >> Hi! >> Pavel gave following examples: eth0:green:link adsl0:green:link adsl0:red:error So we would have e.g.: associated-vl42-device = <&camera1>; >>>

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-30 Thread Rob Herring
On Fri, Nov 30, 2018 at 3:08 PM Pavel Machek wrote: > > Hi! > > > > Pavel gave following examples: > > > > > > eth0:green:link > > > adsl0:green:link > > > adsl0:red:error > > > > > > So we would have e.g.: > > > > > > associated-vl42-device = <&camera1>; > > > associated-network-device = <&phy1>;

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-30 Thread Pavel Machek
Hi! > > Pavel gave following examples: > > > > eth0:green:link > > adsl0:green:link > > adsl0:red:error > > > > So we would have e.g.: > > > > associated-vl42-device = <&camera1>; > > associated-network-device = <&phy1>; > > associated-block-device = <&phy1>; > > Variable property names are kind

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-30 Thread Rob Herring
On Tue, Nov 27, 2018 at 2:38 PM Jacek Anaszewski wrote: > > On 11/13/2018 09:57 PM, Jacek Anaszewski wrote: > > On 11/12/2018 07:27 PM, Rob Herring wrote: > >> On Tue, Nov 06, 2018 at 11:07:12PM +0100, Jacek Anaszewski wrote: > >>> Introduce dedicated properties for conveying information about > >

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-27 Thread Jacek Anaszewski
On 11/13/2018 09:57 PM, Jacek Anaszewski wrote: > On 11/12/2018 07:27 PM, Rob Herring wrote: >> On Tue, Nov 06, 2018 at 11:07:12PM +0100, Jacek Anaszewski wrote: >>> Introduce dedicated properties for conveying information about >>> LED function and color. Mark old "label" property as deprecated. >

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-13 Thread Jacek Anaszewski
On 11/12/2018 07:27 PM, Rob Herring wrote: > On Tue, Nov 06, 2018 at 11:07:12PM +0100, Jacek Anaszewski wrote: >> Introduce dedicated properties for conveying information about >> LED function and color. Mark old "label" property as deprecated. >> >> Signed-off-by: Jacek Anaszewski >> Cc: Baolin W

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-13 Thread Jacek Anaszewski
Hi Vesa, On 11/13/2018 08:10 AM, Vesa Jääskeläinen wrote: > Hi Jacek, > > On 12/11/2018 18.02, Jacek Anaszewski wrote: Support for RGB LEDs, or other variations of LED synchronization have been approached several times, but without satisfying result so far. Generally the

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-12 Thread Vesa Jääskeläinen
Hi Jacek, On 12/11/2018 18.02, Jacek Anaszewski wrote: Support for RGB LEDs, or other variations of LED synchronization have been approached several times, but without satisfying result so far. Generally the problem boils down to the issue of how triggers should handle multiple synchronized LED

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-12 Thread Jacek Anaszewski
Hi Vesa, On 11/10/2018 06:19 PM, Vesa Jääskeläinen wrote: > Hi Jacek, > > On 09/11/2018 22.42, Jacek Anaszewski wrote: >> Hi Vesa, >> >> On 11/09/2018 09:32 AM, Vesa Jääskeläinen wrote: >>> On 07/11/2018 0.07, Jacek Anaszewski wrote: Introduce dedicated properties for conveying information a

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-10 Thread Vesa Jääskeläinen
Hi Jacek, On 09/11/2018 22.42, Jacek Anaszewski wrote: Hi Vesa, On 11/09/2018 09:32 AM, Vesa Jääskeläinen wrote: On 07/11/2018 0.07, Jacek Anaszewski wrote: Introduce dedicated properties for conveying information about LED function and color. Mark old "label" property as deprecated. Signed-

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-09 Thread Jacek Anaszewski
Hi Vesa, On 11/09/2018 09:32 AM, Vesa Jääskeläinen wrote: > On 07/11/2018 0.07, Jacek Anaszewski wrote: >> Introduce dedicated properties for conveying information about >> LED function and color. Mark old "label" property as deprecated. >> >> Signed-off-by: Jacek Anaszewski >> Cc: Baolin Wang >

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-09 Thread Jacek Anaszewski
Dan, On 11/08/2018 10:08 PM, Dan Murphy wrote: > Jacek > > On 11/08/2018 02:47 PM, Jacek Anaszewski wrote: >> Dan, >> >> On 11/08/2018 07:00 PM, Dan Murphy wrote: >>> Jacek >>> >>> On 11/06/2018 04:07 PM, Jacek Anaszewski wrote: Introduce dedicated properties for conveying information about

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-09 Thread Vesa Jääskeläinen
On 07/11/2018 0.07, Jacek Anaszewski wrote: Introduce dedicated properties for conveying information about LED function and color. Mark old "label" property as deprecated. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Daniel Mack Cc: Dan Murphy Cc: Linus Walleij Cc: Oleh Kravchenko C

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-08 Thread Dan Murphy
Jacek On 11/08/2018 02:47 PM, Jacek Anaszewski wrote: > Dan, > > On 11/08/2018 07:00 PM, Dan Murphy wrote: >> Jacek >> >> On 11/06/2018 04:07 PM, Jacek Anaszewski wrote: >>> Introduce dedicated properties for conveying information about >>> LED function and color. Mark old "label" property as dep

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-08 Thread Jacek Anaszewski
Dan, On 11/08/2018 07:00 PM, Dan Murphy wrote: > Jacek > > On 11/06/2018 04:07 PM, Jacek Anaszewski wrote: >> Introduce dedicated properties for conveying information about >> LED function and color. Mark old "label" property as deprecated. >> >> Signed-off-by: Jacek Anaszewski >> Cc: Baolin Wan

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-08 Thread Dan Murphy
Jacek On 11/06/2018 04:07 PM, Jacek Anaszewski wrote: > Introduce dedicated properties for conveying information about > LED function and color. Mark old "label" property as deprecated. > > Signed-off-by: Jacek Anaszewski > Cc: Baolin Wang > Cc: Daniel Mack > Cc: Dan Murphy > Cc: Linus Wallei

[PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-06 Thread Jacek Anaszewski
Introduce dedicated properties for conveying information about LED function and color. Mark old "label" property as deprecated. Signed-off-by: Jacek Anaszewski Cc: Baolin Wang Cc: Daniel Mack Cc: Dan Murphy Cc: Linus Walleij Cc: Oleh Kravchenko Cc: Sakari Ailus Cc: Simon Shields Cc: Xiaoto