Re: [PATCH 04/22] tools lib traceevent: Add jbd2 plugin

2013-11-25 Thread Jiri Olsa
On Mon, Nov 25, 2013 at 10:46:18AM +0100, Jiri Olsa wrote: > > > Shouldn't it unregister these functions when unloaded? > > > > Probably ;-) > > will add, hum... haven't found exported interface to unregister/remove for print function, seems like this is getting freed in the end at: void peve

Re: [PATCH 04/22] tools lib traceevent: Add jbd2 plugin

2013-11-25 Thread Jiri Olsa
On Sat, Nov 23, 2013 at 03:52:21AM -0500, Steven Rostedt wrote: > On Fri, 22 Nov 2013 23:27:57 +0900 > Namhyung Kim wrote: > > > [SNIP] > > > +#define MINORBITS20 > > > +#define MINORMASK((1U << MINORBITS) - 1) > > > + > > > +#define MAJOR(dev) ((unsigned int) ((dev) >> MINO

Re: [PATCH 04/22] tools lib traceevent: Add jbd2 plugin

2013-11-24 Thread Namhyung Kim
On Sat, 23 Nov 2013 03:52:21 -0500, Steven Rostedt wrote: > On Fri, 22 Nov 2013 23:27:57 +0900 > Namhyung Kim wrote: > >> [SNIP] >> > +#define MINORBITS 20 >> > +#define MINORMASK ((1U << MINORBITS) - 1) >> > + >> > +#define MAJOR(dev)((unsigned int) ((dev) >> MINORBITS)) >> > +#define MIN

Re: [PATCH 04/22] tools lib traceevent: Add jbd2 plugin

2013-11-23 Thread Steven Rostedt
On Fri, 22 Nov 2013 23:27:57 +0900 Namhyung Kim wrote: > [SNIP] > > +#define MINORBITS 20 > > +#define MINORMASK ((1U << MINORBITS) - 1) > > + > > +#define MAJOR(dev) ((unsigned int) ((dev) >> MINORBITS)) > > +#define MINOR(dev) ((unsigned int) ((dev) & MINORMASK)) > > + > > +unsigned long long

Re: [PATCH 04/22] tools lib traceevent: Add jbd2 plugin

2013-11-22 Thread Namhyung Kim
2013-11-21 (목), 12:01 +0100, Jiri Olsa: > Backporting jbd2 plugin. > > Backported from Steven Rostedt's trace-cmd repo (HEAD 0f2c2fb): > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git > > This plugin adds field resolving functions for following > tracepoint events: > jbd2:j