Re: [alsa-devel] [PATCH 04/14] soundwire: Add MIPI DisCo property helpers

2017-10-22 Thread Pierre-Louis Bossart
On 10/21/17 5:07 PM, Vinod Koul wrote: On Sat, Oct 21, 2017 at 10:20:46AM +0100, Mark Brown wrote: On Thu, Oct 19, 2017 at 08:33:20AM +0530, Vinod Koul wrote: + /* device is probed so let's read the properties now */ + if (slave->ops && slave->ops->read_prop) + slave-

Re: [PATCH 04/14] soundwire: Add MIPI DisCo property helpers

2017-10-21 Thread Vinod Koul
On Sat, Oct 21, 2017 at 10:20:46AM +0100, Mark Brown wrote: > On Thu, Oct 19, 2017 at 08:33:20AM +0530, Vinod Koul wrote: > > > + /* device is probed so let's read the properties now */ > > + if (slave->ops && slave->ops->read_prop) > > + slave->ops->read_prop(slave); > > Is it vali

Re: [PATCH 04/14] soundwire: Add MIPI DisCo property helpers

2017-10-21 Thread Mark Brown
On Thu, Oct 19, 2017 at 08:33:20AM +0530, Vinod Koul wrote: > + /* device is probed so let's read the properties now */ > + if (slave->ops && slave->ops->read_prop) > + slave->ops->read_prop(slave); Is it valid for us to not be able to read the properties? > + fwn

Re: [alsa-devel] [PATCH 04/14] soundwire: Add MIPI DisCo property helpers

2017-10-19 Thread Vinod Koul
On Thu, Oct 19, 2017 at 11:02:02AM +0200, Takashi Iwai wrote: > On Thu, 19 Oct 2017 05:03:20 +0200, > Vinod Koul wrote: > > > > + slave->ops = drv->ops; > > + > > ret = drv->probe(slave, id); > > if (ret) { > > dev_err(dev, "Probe of %s failed: %d\n", drv->name, ret); > >

Re: [alsa-devel] [PATCH 04/14] soundwire: Add MIPI DisCo property helpers

2017-10-19 Thread Takashi Iwai
On Thu, 19 Oct 2017 05:03:20 +0200, Vinod Koul wrote: > > diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c > index a14d1de80afa..baad4ad3be44 100644 > --- a/drivers/soundwire/bus_type.c > +++ b/drivers/soundwire/bus_type.c > @@ -139,12 +139,28 @@ static int sdw_drv_probe(st

[PATCH 04/14] soundwire: Add MIPI DisCo property helpers

2017-10-18 Thread Vinod Koul
MIPI Discovery And Configuration (DisCo) Specification for SoundWire specifies properties to be implemented for SoundWire Masters and Slaves. The DisCo spec doesn't mandate these properties. However, SDW bus cannot work without knowing these values. The bus helper functions read the Master and Sla