Re: [PATCH 03/35] UBI: Fastmap: Add self check to detect absent PEBs

2014-11-05 Thread Artem Bityutskiy
On Wed, 2014-11-05 at 17:05 +0100, Richard Weinberger wrote: > Am 05.11.2014 um 17:01 schrieb Artem Bityutskiy: > > On Wed, 2014-11-05 at 16:56 +0100, Richard Weinberger wrote: > >> I did that to have alloc and free balanced. > >> I.e. to not have a naked kfree(). Always when I see a kfree() > >>

Re: [PATCH 03/35] UBI: Fastmap: Add self check to detect absent PEBs

2014-11-05 Thread Richard Weinberger
Am 05.11.2014 um 17:01 schrieb Artem Bityutskiy: > On Wed, 2014-11-05 at 16:56 +0100, Richard Weinberger wrote: >> I did that to have alloc and free balanced. >> I.e. to not have a naked kfree(). Always when I see a kfree() >> somewhere >> I'd like to see the k*alloc(). > > OK. Please, just make

Re: [PATCH 03/35] UBI: Fastmap: Add self check to detect absent PEBs

2014-11-05 Thread Artem Bityutskiy
On Wed, 2014-11-05 at 16:56 +0100, Richard Weinberger wrote: > I did that to have alloc and free balanced. > I.e. to not have a naked kfree(). Always when I see a kfree() > somewhere > I'd like to see the k*alloc(). OK. Please, just make the comment simpler then. Say that you are freeing the debu

Re: [PATCH 03/35] UBI: Fastmap: Add self check to detect absent PEBs

2014-11-05 Thread Richard Weinberger
Am 05.11.2014 um 16:23 schrieb Artem Bityutskiy: > On Wed, 2014-10-29 at 13:45 +0100, Richard Weinberger wrote: >> This self check allows Fastmap to detect absent PEBs while >> writing a new fastmap to the MTD device. >> It will help to find implementation issues in Fastmap. >> >> Signed-off-by: Ri

Re: [PATCH 03/35] UBI: Fastmap: Add self check to detect absent PEBs

2014-11-05 Thread Artem Bityutskiy
On Wed, 2014-10-29 at 13:45 +0100, Richard Weinberger wrote: > This self check allows Fastmap to detect absent PEBs while > writing a new fastmap to the MTD device. > It will help to find implementation issues in Fastmap. > > Signed-off-by: Richard Weinberger > --- > drivers/mtd/ubi/fastmap.c |

[PATCH 03/35] UBI: Fastmap: Add self check to detect absent PEBs

2014-10-29 Thread Richard Weinberger
This self check allows Fastmap to detect absent PEBs while writing a new fastmap to the MTD device. It will help to find implementation issues in Fastmap. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/fastmap.c | 86 +-- 1 file changed, 84 inse