Re: [PATCH 03/25] Unionfs: display informational messages only if debug is on

2007-09-26 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Jan Engelhardt writes: [...] > Surprise, pr_debug() is just that all nicely wrapped up. > Want debug? Do it like this. > > #ifdef CONFIG_UNIONFS_DEBUG > # define DEBUG 1 > #endif > > and pr_debug() works magic. [...] Sounds good. I'll do that. Thanks, Erez.

Re: [PATCH 03/25] Unionfs: display informational messages only if debug is on

2007-09-26 Thread Jan Engelhardt
On Sep 26 2007 10:01, Erez Zadok wrote: >> >> On Sep 25 2007 23:09, Erez Zadok wrote: >> >--- a/fs/unionfs/commonfops.c >> >+++ b/fs/unionfs/commonfops.c >> >@@ -394,8 +394,8 @@ int unionfs_file_revalidate(struct file *file, bool >> >willwrite) >> >if (willwrite && IS_WRITE_FLAG(file->f_flag

Re: [PATCH 03/25] Unionfs: display informational messages only if debug is on

2007-09-26 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Jan Engelhardt writes: > > On Sep 25 2007 23:09, Erez Zadok wrote: > >--- a/fs/unionfs/commonfops.c > >+++ b/fs/unionfs/commonfops.c > >@@ -394,8 +394,8 @@ int unionfs_file_revalidate(struct file *file, bool > >willwrite) > > if (willwrite && IS_WRITE_FLAG(file

Re: [PATCH 03/25] Unionfs: display informational messages only if debug is on

2007-09-26 Thread Jan Engelhardt
On Sep 25 2007 23:09, Erez Zadok wrote: >--- a/fs/unionfs/commonfops.c >+++ b/fs/unionfs/commonfops.c >@@ -394,8 +394,8 @@ int unionfs_file_revalidate(struct file *file, bool >willwrite) > if (willwrite && IS_WRITE_FLAG(file->f_flags) && > !IS_WRITE_FLAG(unionfs_lower_file(file)->

[PATCH 03/25] Unionfs: display informational messages only if debug is on

2007-09-25 Thread Erez Zadok
This is to avoid filling the console/logs with messages that are primarily of debugging use. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c |4 ++-- fs/unionfs/dentry.c |6 +++--- fs/unionfs/union.h |