Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information

2015-08-21 Thread Javier Martinez Canillas
Hello Brian, On 08/22/2015 03:05 AM, Brian Norris wrote: > On Sat, Aug 22, 2015 at 02:26:14AM +0200, Javier Martinez Canillas wrote: >> On 08/22/2015 12:47 AM, Brian Norris wrote: >>> Otherwise, looks good. I'll either patch in this commit message, or >>> await v2. Your call. >> >> If you don't mi

Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information

2015-08-21 Thread Brian Norris
On Sat, Aug 22, 2015 at 02:26:14AM +0200, Javier Martinez Canillas wrote: > On 08/22/2015 12:47 AM, Brian Norris wrote: > > Otherwise, looks good. I'll either patch in this commit message, or > > await v2. Your call. > > If you don't mind fixing it up yourself when applying, then that > would be r

Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information

2015-08-21 Thread Javier Martinez Canillas
Hello Brian, On 08/22/2015 12:47 AM, Brian Norris wrote: > Hi Javier, > > On Fri, Aug 21, 2015 at 12:57:54AM +0200, Javier Martinez Canillas wrote: >> On 08/21/2015 12:34 AM, Brian Norris wrote: >>> On Fri, Aug 21, 2015 at 12:13:34AM +0200, Javier Martinez Canillas wrote: So this patch reall

Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information

2015-08-21 Thread Brian Norris
Hi Javier, On Fri, Aug 21, 2015 at 12:57:54AM +0200, Javier Martinez Canillas wrote: > On 08/21/2015 12:34 AM, Brian Norris wrote: > > On Fri, Aug 21, 2015 at 12:13:34AM +0200, Javier Martinez Canillas wrote: > >> So this patch really is a no-op right now and is not fixing anything. > >> As long a

Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information

2015-08-20 Thread Javier Martinez Canillas
Hello Brian, On 08/21/2015 12:34 AM, Brian Norris wrote: > On Fri, Aug 21, 2015 at 12:13:34AM +0200, Javier Martinez Canillas wrote: >> So this patch really is a no-op right now and is not fixing anything. >> As long as the driver has a MODULE_DEVICE_TABLE(spi,...), things will > > This driver do

Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information

2015-08-20 Thread Brian Norris
On Fri, Aug 21, 2015 at 12:13:34AM +0200, Javier Martinez Canillas wrote: > So this patch really is a no-op right now and is not fixing anything. > As long as the driver has a MODULE_DEVICE_TABLE(spi,...), things will This driver does not have a MODULE_DEVICE_TABLE() at all, nor does it use spi_de

Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information

2015-08-20 Thread Javier Martinez Canillas
Hello Brian, On 08/20/2015 11:54 PM, Brian Norris wrote: > On Thu, Aug 20, 2015 at 09:07:16AM +0200, Javier Martinez Canillas wrote: >> The SPI core always reports the MODALIAS uevent as "spi:" >> regardless of the mechanism that was used to register the device >> (i.e: OF or board code) and the t

Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 09:07:16AM +0200, Javier Martinez Canillas wrote: > The SPI core always reports the MODALIAS uevent as "spi:" > regardless of the mechanism that was used to register the device > (i.e: OF or board code) and the table that is used later to match > the driver with the device (

[PATCH 03/18] mtd: dataflash: Export OF module alias information

2015-08-20 Thread Javier Martinez Canillas
The SPI core always reports the MODALIAS uevent as "spi:" regardless of the mechanism that was used to register the device (i.e: OF or board code) and the table that is used later to match the driver with the device (i.e: SPI id table or OF match table). So drivers needs to export the SPI id table