Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

2016-07-21 Thread Grzegorz Jaszczyk
Hi Russel, Thmoas 2016-07-21 14:46 GMT+02:00 Thomas Petazzoni : > Hello, > > On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote: >> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote: >> > Signed-off-by: Grzegorz Jaszczyk >> >> Why? It's not like this is an on-soc

Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

2016-07-21 Thread Thomas Petazzoni
Hello, On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote: > On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote: > > Signed-off-by: Grzegorz Jaszczyk > > Why? It's not like this is an on-soc device, but most likely a PCIe card. > Should we build-in all PCIe driv

Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

2016-07-21 Thread Russell King - ARM Linux
On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote: > Signed-off-by: Grzegorz Jaszczyk Why? It's not like this is an on-soc device, but most likely a PCIe card. Should we build-in all PCIe drivers? I think it makes more sense to have this as a module rather than built-in. -- RM

[PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

2016-07-21 Thread Grzegorz Jaszczyk
Signed-off-by: Grzegorz Jaszczyk --- arch/arm/configs/mvebu_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig index f1a0e25..000a866 100644 --- a/arch/arm/configs/mvebu_v7_defconfig +++ b/arch/arm/configs/mv