Re: [PATCH 03/16] vfs: don't evict uninitialized inode

2018-08-16 Thread Amir Goldstein
On Mon, Jul 30, 2018 at 10:41 AM Miklos Szeredi wrote: > > On Mon, Jul 30, 2018 at 7:09 AM, Amir Goldstein wrote: > > On Mon, Jul 30, 2018 at 1:04 AM, Al Viro wrote: > >> From: Miklos Szeredi > >> > >> iput() ends up calling ->evict() on new inode, which is not yet initialized > >> by owning fs

Re: [PATCH 03/16] vfs: don't evict uninitialized inode

2018-07-30 Thread Miklos Szeredi
On Mon, Jul 30, 2018 at 7:09 AM, Amir Goldstein wrote: > On Mon, Jul 30, 2018 at 1:04 AM, Al Viro wrote: >> From: Miklos Szeredi >> >> iput() ends up calling ->evict() on new inode, which is not yet initialized >> by owning fs. So use destroy_inode() instead. >> >> Add to sb->s_inodes list only

Re: [PATCH 03/16] vfs: don't evict uninitialized inode

2018-07-29 Thread Amir Goldstein
On Mon, Jul 30, 2018 at 1:04 AM, Al Viro wrote: > From: Miklos Szeredi > > iput() ends up calling ->evict() on new inode, which is not yet initialized > by owning fs. So use destroy_inode() instead. > > Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning > that it wasn't a

[PATCH 03/16] vfs: don't evict uninitialized inode

2018-07-29 Thread Al Viro
From: Miklos Szeredi iput() ends up calling ->evict() on new inode, which is not yet initialized by owning fs. So use destroy_inode() instead. Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning that it wasn't allocated with new_inode(), which already does the insertion).