Re: [PATCH 03/16] uuid: rename uuid types

2017-05-11 Thread Andy Shevchenko
On Wed, 2017-05-10 at 19:20 +0100, David Howells wrote: > Christoph Hellwig wrote: > > > -#define NULL_UUID_LE > > \ > > - UUID_LE(0x, 0x, 0x, 0x00, 0x00, 0x00, 0x00, > > \ > > - 0x00, 0x00, 0x00, 0x00) > > +#defin

Re: [PATCH 03/16] uuid: rename uuid types

2017-05-11 Thread Amir Goldstein
On Thu, May 11, 2017 at 10:59 AM, Christoph Hellwig wrote: > On Wed, May 10, 2017 at 10:15:51PM +0300, Amir Goldstein wrote: >> > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) >> > { >> > - return memcmp(&u1, &u2, sizeof(uuid_be)); >> > + return memcmp(&u1, &u2, sizeof

Re: [PATCH 03/16] uuid: rename uuid types

2017-05-11 Thread Christoph Hellwig
On Wed, May 10, 2017 at 10:15:51PM +0300, Amir Goldstein wrote: > > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) > > { > > - return memcmp(&u1, &u2, sizeof(uuid_be)); > > + return memcmp(&u1, &u2, sizeof(uuid_t)); > > } > > > > > I think we should use this opportuni

Re: [PATCH 03/16] uuid: rename uuid types

2017-05-10 Thread Amir Goldstein
On Wed, May 10, 2017 at 9:02 PM, Christoph Hellwig wrote: > Our "little endian" UUID really is a Wintel GUID, so rename it and its > helpers such (guid_t). The big endian UUID is the only true one, so > give it the name uuid_t. The uuid_le and uuid_be names are retained for, > but will hopefully

Re: [PATCH 03/16] uuid: rename uuid types

2017-05-10 Thread David Howells
Christoph Hellwig wrote: > -#define NULL_UUID_LE \ > - UUID_LE(0x, 0x, 0x, 0x00, 0x00, 0x00, 0x00, \ > - 0x00, 0x00, 0x00, 0x00) > +#define NULL_GUID\ > + GU

[PATCH 03/16] uuid: rename uuid types

2017-05-10 Thread Christoph Hellwig
Our "little endian" UUID really is a Wintel GUID, so rename it and its helpers such (guid_t). The big endian UUID is the only true one, so give it the name uuid_t. The uuid_le and uuid_be names are retained for, but will hopefully go away soon. Also remove the existing typedef in XFS that's now