Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

2014-09-22 Thread Scott Wood
On Mon, 2014-09-22 at 11:26 +0300, Laurentiu Tudor wrote: > On 09/19/2014 11:19 PM, Scott Wood wrote: > > On Fri, 2014-09-19 at 15:16 -0500, Scott Wood wrote: > >> On Thu, 2014-09-18 at 18:26 +1000, Michael Neuling wrote: > >>> From: Ian Munsie > >>> > >>> Currently msi_bitmap_alloc_hwirqs() will

Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

2014-09-22 Thread Michael Neuling
> > diff --git a/arch/powerpc/sysdev/msi_bitmap.c > > b/arch/powerpc/sysdev/msi_bitmap.c > > index 2ff6302..e001559 100644 > > --- a/arch/powerpc/sysdev/msi_bitmap.c > > +++ b/arch/powerpc/sysdev/msi_bitmap.c > > @@ -24,28 +24,36 @@ int msi_bitmap_alloc_hwirqs(struct msi_bitmap *bmp, int > > num)

Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

2014-09-22 Thread Laurentiu Tudor
Hi Michael, Minor comment inline. On 09/18/2014 11:26 AM, Michael Neuling wrote: > From: Ian Munsie > > Currently msi_bitmap_alloc_hwirqs() will round up any IRQ allocation requests > to the nearest power of 2. eg. ask for 5 IRQs and you'll get 8. This wastes > a > lot of IRQs which can be a

Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

2014-09-22 Thread Laurentiu Tudor
On 09/19/2014 11:19 PM, Scott Wood wrote: > On Fri, 2014-09-19 at 15:16 -0500, Scott Wood wrote: >> On Thu, 2014-09-18 at 18:26 +1000, Michael Neuling wrote: >>> From: Ian Munsie >>> >>> Currently msi_bitmap_alloc_hwirqs() will round up any IRQ allocation >>> requests >>> to the nearest power of

Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

2014-09-22 Thread Laurentiu Tudor
On 09/19/2014 11:16 PM, Scott Wood wrote: > On Thu, 2014-09-18 at 18:26 +1000, Michael Neuling wrote: >> From: Ian Munsie >> >> Currently msi_bitmap_alloc_hwirqs() will round up any IRQ allocation requests >> to the nearest power of 2. eg. ask for 5 IRQs and you'll get 8. This >> wastes a >> lo

Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

2014-09-19 Thread Scott Wood
On Fri, 2014-09-19 at 15:16 -0500, Scott Wood wrote: > On Thu, 2014-09-18 at 18:26 +1000, Michael Neuling wrote: > > From: Ian Munsie > > > > Currently msi_bitmap_alloc_hwirqs() will round up any IRQ allocation > > requests > > to the nearest power of 2. eg. ask for 5 IRQs and you'll get 8. Th

Re: [PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

2014-09-19 Thread Scott Wood
On Thu, 2014-09-18 at 18:26 +1000, Michael Neuling wrote: > From: Ian Munsie > > Currently msi_bitmap_alloc_hwirqs() will round up any IRQ allocation requests > to the nearest power of 2. eg. ask for 5 IRQs and you'll get 8. This wastes > a > lot of IRQs which can be a scarce resource. > > Fo

[PATCH 03/15] powerpc/msi: Improve IRQ bitmap allocator

2014-09-18 Thread Michael Neuling
From: Ian Munsie Currently msi_bitmap_alloc_hwirqs() will round up any IRQ allocation requests to the nearest power of 2. eg. ask for 5 IRQs and you'll get 8. This wastes a lot of IRQs which can be a scarce resource. For cxl we can require multiple IRQs for every contexts that is attached to t