Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-13 Thread Rob Herring
On Fri, Aug 10, 2018 at 2:09 PM Palmer Dabbelt wrote: > > On Fri, 10 Aug 2018 09:57:03 PDT (-0700), robh...@kernel.org wrote: > > On Thu, Aug 9, 2018 at 12:29 AM Palmer Dabbelt wrote: > >> > >> On Wed, 08 Aug 2018 16:32:07 PDT (-0700), robh...@kernel.org wrote: > >> > On Wed, Aug 8, 2018 at 1:38

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-10 Thread Palmer Dabbelt
On Fri, 10 Aug 2018 09:57:03 PDT (-0700), robh...@kernel.org wrote: On Thu, Aug 9, 2018 at 12:29 AM Palmer Dabbelt wrote: On Wed, 08 Aug 2018 16:32:07 PDT (-0700), robh...@kernel.org wrote: > On Wed, Aug 8, 2018 at 1:38 PM Palmer Dabbelt wrote: >> >> On Wed, 08 Aug 2018 07:16:14 PDT (-0700),

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-10 Thread Rob Herring
On Thu, Aug 9, 2018 at 12:29 AM Palmer Dabbelt wrote: > > On Wed, 08 Aug 2018 16:32:07 PDT (-0700), robh...@kernel.org wrote: > > On Wed, Aug 8, 2018 at 1:38 PM Palmer Dabbelt wrote: > >> > >> On Wed, 08 Aug 2018 07:16:14 PDT (-0700), robh...@kernel.org wrote: > >> > On Tue, Aug 7, 2018 at 8:17 P

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-09 Thread Marc Zyngier
On 08/08/18 17:57, Christoph Hellwig wrote: > On Wed, Aug 08, 2018 at 05:47:40PM +0100, Marc Zyngier wrote: >> The original GIC driver deals with 2.5 revisions of the architecture >> (yes, there was something pre-GICv1...), and implementers have been >> creative to the extreme. Still, we could have

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-08 Thread Christoph Hellwig
On Wed, Aug 08, 2018 at 11:29:17PM -0700, Palmer Dabbelt wrote: >> So I guess to answer my question, you are just making up version >> numbers. Unless you are doing the IP verilog too, don't do that. > > Well, in this case my proposal would be that we change the hardware team's > versioning scheme

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-08 Thread Palmer Dabbelt
On Wed, 08 Aug 2018 16:32:07 PDT (-0700), robh...@kernel.org wrote: On Wed, Aug 8, 2018 at 1:38 PM Palmer Dabbelt wrote: On Wed, 08 Aug 2018 07:16:14 PDT (-0700), robh...@kernel.org wrote: > On Tue, Aug 7, 2018 at 8:17 PM Palmer Dabbelt wrote: >> >> On Mon, 06 Aug 2018 13:59:48 PDT (-0700), r

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-08 Thread Rob Herring
On Wed, Aug 8, 2018 at 1:38 PM Palmer Dabbelt wrote: > > On Wed, 08 Aug 2018 07:16:14 PDT (-0700), robh...@kernel.org wrote: > > On Tue, Aug 7, 2018 at 8:17 PM Palmer Dabbelt wrote: > >> > >> On Mon, 06 Aug 2018 13:59:48 PDT (-0700), robh...@kernel.org wrote: > >> > On Thu, Aug 2, 2018 at 4:08 PM

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-08 Thread Palmer Dabbelt
On Wed, 08 Aug 2018 07:16:14 PDT (-0700), robh...@kernel.org wrote: On Tue, Aug 7, 2018 at 8:17 PM Palmer Dabbelt wrote: On Mon, 06 Aug 2018 13:59:48 PDT (-0700), robh...@kernel.org wrote: > On Thu, Aug 2, 2018 at 4:08 PM Atish Patra wrote: >> >> On 8/2/18 4:50 AM, Christoph Hellwig wrote: >>

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-08 Thread Christoph Hellwig
On Wed, Aug 08, 2018 at 05:47:40PM +0100, Marc Zyngier wrote: > The original GIC driver deals with 2.5 revisions of the architecture > (yes, there was something pre-GICv1...), and implementers have been > creative to the extreme. Still, we could have done without most of these > compat strings. Hin

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-08 Thread Marc Zyngier
On 08/08/18 16:09, Christoph Hellwig wrote: > On Wed, Aug 08, 2018 at 08:16:14AM -0600, Rob Herring wrote: >> Is 1.0 an actual version number corresponding to an exact, revision >> controlled version of the IP or just something you made up? Looks like >> the latter to me and I'm not a fan of s/w fo

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-08 Thread Christoph Hellwig
On Wed, Aug 08, 2018 at 08:16:14AM -0600, Rob Herring wrote: > Is 1.0 an actual version number corresponding to an exact, revision > controlled version of the IP or just something you made up? Looks like > the latter to me and I'm not a fan of s/w folks making up version > numbers for h/w. Standard

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-08 Thread Rob Herring
On Tue, Aug 7, 2018 at 8:17 PM Palmer Dabbelt wrote: > > On Mon, 06 Aug 2018 13:59:48 PDT (-0700), robh...@kernel.org wrote: > > On Thu, Aug 2, 2018 at 4:08 PM Atish Patra wrote: > >> > >> On 8/2/18 4:50 AM, Christoph Hellwig wrote: > >> > From: Palmer Dabbelt > >> > > >> > This patch adds docum

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-07 Thread Atish Patra
On 8/7/18 7:17 PM, Palmer Dabbelt wrote: On Mon, 06 Aug 2018 13:59:48 PDT (-0700), robh...@kernel.org wrote: On Thu, Aug 2, 2018 at 4:08 PM Atish Patra wrote: On 8/2/18 4:50 AM, Christoph Hellwig wrote: From: Palmer Dabbelt This patch adds documentation for the platform-level interrupt con

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-07 Thread Palmer Dabbelt
On Mon, 06 Aug 2018 13:59:48 PDT (-0700), robh...@kernel.org wrote: On Thu, Aug 2, 2018 at 4:08 PM Atish Patra wrote: On 8/2/18 4:50 AM, Christoph Hellwig wrote: > From: Palmer Dabbelt > > This patch adds documentation for the platform-level interrupt > controller (PLIC) found in all RISC-V s

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-07 Thread Christoph Hellwig
On Mon, Aug 06, 2018 at 02:59:48PM -0600, Rob Herring wrote: > > > +Required properties: > > > +- compatible : "sifive,plic0" > > > +- #address-cells : should be <0> > > > +- #interrupt-cells : should be <1> > > > +- interrupt-controller : Identifies the node as an interrupt controller > > > +- reg

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-06 Thread Rob Herring
On Thu, Aug 2, 2018 at 4:08 PM Atish Patra wrote: > > On 8/2/18 4:50 AM, Christoph Hellwig wrote: > > From: Palmer Dabbelt > > > > This patch adds documentation for the platform-level interrupt > > controller (PLIC) found in all RISC-V systems. This interrupt > > controller routes interrupts fro

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-03 Thread Christoph Hellwig
On Thu, Aug 02, 2018 at 03:08:15PM -0700, Atish Patra wrote: > The one in the real device tree has two entries. > reg = <0x 0x0c00 0x 0x0400>; > > Is it intentional or just incorrect entry left over from earlier days? I'll need to SiFive folks to comment on that. The drive

Re: [PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-02 Thread Atish Patra
On 8/2/18 4:50 AM, Christoph Hellwig wrote: From: Palmer Dabbelt This patch adds documentation for the platform-level interrupt controller (PLIC) found in all RISC-V systems. This interrupt controller routes interrupts from all the devices in the system to each hart-local interrupt controller.

[PATCH 03/11] dt-bindings: interrupt-controller: RISC-V PLIC documentation

2018-08-02 Thread Christoph Hellwig
From: Palmer Dabbelt This patch adds documentation for the platform-level interrupt controller (PLIC) found in all RISC-V systems. This interrupt controller routes interrupts from all the devices in the system to each hart-local interrupt controller. Note: the DTS bindings for the PLIC aren't s