Re: [PATCH 03/10] b43: Remove uninitialized_var() usage

2020-06-05 Thread Kalle Valo
Kees Cook writes: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the variable or make compiler changes.

Re: [PATCH 03/10] b43: Remove uninitialized_var() usage

2020-06-04 Thread Nick Desaulniers
On Thu, Jun 4, 2020 at 1:18 PM Kees Cook wrote: > > On Thu, Jun 04, 2020 at 01:08:44PM -0700, Nick Desaulniers wrote: > > On Wed, Jun 3, 2020 at 4:32 PM Kees Cook wrote: > > > > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > > (or can in the future), and suppresses

Re: [PATCH 03/10] b43: Remove uninitialized_var() usage

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 01:08:44PM -0700, Nick Desaulniers wrote: > On Wed, Jun 3, 2020 at 4:32 PM Kees Cook wrote: > > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings (e.g. > > "unused variable"). If

Re: [PATCH 03/10] b43: Remove uninitialized_var() usage

2020-06-04 Thread Nick Desaulniers
On Wed, Jun 3, 2020 at 4:32 PM Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the vari

[PATCH 03/10] b43: Remove uninitialized_var() usage

2020-06-03 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2