Re: [PATCH 0244/1285] Replace numeric parameter like 0444 with macro

2016-08-10 Thread Linus Walleij
On Tue, Aug 2, 2016 at 12:52 PM, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and t

Re: [PATCH 0244/1285] Replace numeric parameter like 0444 with macro

2016-08-10 Thread Arnd Bergmann
On Wednesday, August 10, 2016 3:02:05 PM CEST Linus Walleij wrote: > On Tue, Aug 2, 2016 at 12:52 PM, Baole Ni wrote: > > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access > > permission. > > As we know, thes

Re: [PATCH 0244/1285] Replace numeric parameter like 0444 with macro

2016-08-10 Thread Wolfram Sang
> > I assume Wolfram will merge this. > > I assume not, see http://lwn.net/Articles/696227/ Thanks for the pointer. I missed the discussion but came up with the same conclusions: a) octals are easier to read and b) original author should have asked if this change was feasible before posting 1285

[PATCH 0244/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of