Re: [PATCH 02/14] perf tools: Introduce struct add_entry_iter

2013-11-04 Thread Namhyung Kim
On Fri, 1 Nov 2013 13:09:09 +0100, Jiri Olsa wrote: > On Thu, Oct 31, 2013 at 03:56:04PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim > > SNIP > >> +} >> + >> +static int >> +iter_add_next_nop_entry(struct add_entry_iter *iter __maybe_unused, >> +struct addr_location *al __

Re: [PATCH 02/14] perf tools: Introduce struct add_entry_iter

2013-11-04 Thread Namhyung Kim
Hi Jiri, On Fri, 1 Nov 2013 13:07:35 +0100, Jiri Olsa wrote: > On Thu, Oct 31, 2013 at 03:56:04PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim > > SNIP > >> + >> +static int >> +perf_evsel__add_entry(struct perf_evsel *evsel, struct addr_location *al, >> + struct perf_sample

Re: [PATCH 02/14] perf tools: Introduce struct add_entry_iter

2013-11-01 Thread Jiri Olsa
On Thu, Oct 31, 2013 at 03:56:04PM +0900, Namhyung Kim wrote: > From: Namhyung Kim SNIP > +} > + > +static int > +iter_add_next_nop_entry(struct add_entry_iter *iter __maybe_unused, > + struct addr_location *al __maybe_unused) > +{ > + return 0; > +} > + > +static int > +

Re: [PATCH 02/14] perf tools: Introduce struct add_entry_iter

2013-11-01 Thread Jiri Olsa
On Thu, Oct 31, 2013 at 03:56:04PM +0900, Namhyung Kim wrote: > From: Namhyung Kim SNIP > + > +static int > +perf_evsel__add_entry(struct perf_evsel *evsel, struct addr_location *al, > + struct perf_sample *sample, struct machine *machine, > + struct add_entry

[PATCH 02/14] perf tools: Introduce struct add_entry_iter

2013-10-31 Thread Namhyung Kim
From: Namhyung Kim There're some duplicate code when adding hist entries. They are different in that some have branch info or mem info but generally do same thing. So introduce new struct add_entry_iter and add callbacks to customize each case in general way. The new perf_evsel__add_entry() fu