Re: [PATCH 01/35] fs: introduce dmemfs module

2020-11-12 Thread yulei zhang
On Thu, Nov 12, 2020 at 7:09 AM Al Viro wrote: > > On Wed, Nov 11, 2020 at 04:53:00PM +0800, yulei zhang wrote: > > > > ... same here, seeing that you only call that thing from the next two > > > functions > > > and you do *not* provide ->mknod() as a method (unsurprisingly - what > > > would >

Re: [PATCH 01/35] fs: introduce dmemfs module

2020-11-11 Thread Al Viro
On Wed, Nov 11, 2020 at 04:53:00PM +0800, yulei zhang wrote: > > ... same here, seeing that you only call that thing from the next two > > functions > > and you do *not* provide ->mknod() as a method (unsurprisingly - what would > > device nodes do there?) > > > > Thanks for pointing this out. w

Re: [PATCH 01/35] fs: introduce dmemfs module

2020-11-11 Thread yulei zhang
On Wed, Nov 11, 2020 at 4:04 AM Al Viro wrote: > > On Thu, Oct 08, 2020 at 03:53:51PM +0800, yulei.ker...@gmail.com wrote: > > > +static struct inode * > > +dmemfs_get_inode(struct super_block *sb, const struct inode *dir, umode_t > > mode, > > + dev_t dev); > > WTF is 'dev' for? > >

Re: [PATCH 01/35] fs: introduce dmemfs module

2020-11-10 Thread Al Viro
On Thu, Oct 08, 2020 at 03:53:51PM +0800, yulei.ker...@gmail.com wrote: > +static struct inode * > +dmemfs_get_inode(struct super_block *sb, const struct inode *dir, umode_t > mode, > + dev_t dev); WTF is 'dev' for? > +static int > +dmemfs_mknod(struct inode *dir, struct dentry *de

[PATCH 01/35] fs: introduce dmemfs module

2020-10-08 Thread yulei . kernel
From: Yulei Zhang dmemfs (Direct Memory filesystem) is device memory or reserved memory based filesystem. This kind of memory is special as it is not managed by kernel and it is without 'struct page'. The original purpose of dmemfs is to drop the usage of 'struct page' to save extra system memor