Re: [PATCH 01/22] dma-debug: move initialization to common code

2018-04-24 Thread Christoph Hellwig
On Fri, Apr 20, 2018 at 11:23:43AM +0100, Robin Murphy wrote: >> -void dma_debug_init(u32 num_entries) >> +static int dma_debug_init(void) >> { >> +u32 num_entries; > > Maybe initialise it to PREALLOC_DMA_DEBUG_ENTRIES? We initialize it down in an if/else clause which seems a little more cle

Re: [PATCH 01/22] dma-debug: move initialization to common code

2018-04-20 Thread Robin Murphy
Hi Christoph, Nice cleanup! Looks good overall, just a couple of nits. On 20/04/18 09:02, Christoph Hellwig wrote: [...] diff --git a/lib/dma-debug.c b/lib/dma-debug.c index 7f5cdc1e6b29..712a897174e4 100644 --- a/lib/dma-debug.c +++ b/lib/dma-debug.c @@ -41,6 +41,11 @@ #define HASH_FN_SHIFT

[PATCH 01/22] dma-debug: move initialization to common code

2018-04-20 Thread Christoph Hellwig
Most mainstream architectures are using 65536 entries, so lets stick to that. If someone is really desperate to override it that can still be done through , but I'd rather see a really good rationale for that. Signed-off-by: Christoph Hellwig --- arch/arm/mm/dma-mapping-nommu.c | 9 -