Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-18 Thread Tejun Heo
Hello, On Fri, Sep 18, 2015 at 08:42:26AM -0700, Lee Duncan wrote: > To be clear: you would like a patch series that converts the users of > the ida_* routines in my patches to instead use the ida_simple_* > routines, correct? And of course the ida_* helper routines I was adding > in idr.h would n

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-18 Thread Lee Duncan
On 09/15/2015 11:41 AM, Tejun Heo wrote: > Hello, > > On Tue, Sep 15, 2015 at 11:38:42AM -0700, James Bottomley wrote: >> For most of the SCSI stuff, yes. I'm less sure about the sd numbers. >> They go up very high and get hammered a lot during system bring up and >> hot plug. I think having the

[PATCH 01/17] Add ida and idr helper routines.

2015-09-16 Thread Lee Duncan
Clients of the ida and idr index-management routines tend to use the same calling sequences much of the time, so this change adds helper functions for allocating and releasing indexes of either flavor, i.e. with or without pointer management. Inline functions added for idr: idr_get_index_in_rang

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-15 Thread Tejun Heo
Hello, On Tue, Sep 15, 2015 at 11:38:42AM -0700, James Bottomley wrote: > For most of the SCSI stuff, yes. I'm less sure about the sd numbers. > They go up very high and get hammered a lot during system bring up and > hot plug. I think having their own lock rather than wrapping everything > arou

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-15 Thread James Bottomley
On Tue, 2015-09-15 at 14:27 -0400, Tejun Heo wrote: > Hello, > > On Tue, Sep 15, 2015 at 09:46:01AM -0700, Lee Duncan wrote: > > +/** > > + * ida_get_index - allocate a ida index value > > + * @idaidr handle > > + * @lock spinlock handle protecting this index > > + * @p_id pointer

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-15 Thread Tejun Heo
Hello, On Tue, Sep 15, 2015 at 09:46:01AM -0700, Lee Duncan wrote: > +/** > + * ida_get_index - allocate a ida index value > + * @ida idr handle > + * @lock spinlock handle protecting this index > + * @p_id pointer to allocated index value > + * > + * A helper function for saf

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-15 Thread James Bottomley
On Tue, 2015-09-15 at 09:46 -0700, Lee Duncan wrote: > Clients of the ida and idr index-management routines > tend to use the same calling sequences much of the time, > so this change adds helper functions for allocating and > releasing indexes of either flavor, i.e. with or > without pointer manag

[PATCH 01/17] Add ida and idr helper routines.

2015-09-15 Thread Lee Duncan
Clients of the ida and idr index-management routines tend to use the same calling sequences much of the time, so this change adds helper functions for allocating and releasing indexes of either flavor, i.e. with or without pointer management. Inline functions added for idr: idr_get_index_in_rang