Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-31 Thread Muhammad Usama Anjum
On 1/10/25 5:12 AM, Andrew Morton wrote: > On Thu, 9 Jan 2025 09:50:45 -0800 Kees Cook wrote: > >> On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote: >>> For the all other case, why should we keep argv/argc and mark them unused >>> as well when they aren't being used? >> >> I'm

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-31 Thread Muhammad Usama Anjum
On 1/11/25 12:00 AM, David Laight wrote: > On Thu, 9 Jan 2025 22:38:27 +0500 > Muhammad Usama Anjum wrote: > >> Remove the following warnings by removing unused argc and argv >> parameters: >> In function ‘main’: >> warning: unused parameter ‘argc’ [-Wunused-parameter] >> 158 | int main(in

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-10 Thread David Laight
On Thu, 9 Jan 2025 22:38:27 +0500 Muhammad Usama Anjum wrote: > Remove the following warnings by removing unused argc and argv > parameters: > In function ‘main’: > warning: unused parameter ‘argc’ [-Wunused-parameter] > 158 | int main(int argc, char *argv[]) > | ^~~~

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Andrew Morton
On Thu, 9 Jan 2025 09:50:45 -0800 Kees Cook wrote: > On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote: > > For the all other case, why should we keep argv/argc and mark them unused > > as well when they aren't being used? > > I'm fine either way, but my personal code style in

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Kees Cook
On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote: > For the all other case, why should we keep argv/argc and mark them unused > as well when they aren't being used? I'm fine either way, but my personal code style instinct is to keep the "standard" main declaration with argc/arg

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Muhammad Usama Anjum
On 1/9/25 10:42 PM, Kees Cook wrote: > On Thu, Jan 09, 2025 at 10:38:27PM +0500, Muhammad Usama Anjum wrote: >> Remove the following warnings by removing unused argc and argv >> parameters: >> In function ‘main’: >> warning: unused parameter ‘argc’ [-Wunused-parameter] >> 158 | int main(int a

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Kees Cook
On Thu, Jan 09, 2025 at 10:38:27PM +0500, Muhammad Usama Anjum wrote: > Remove the following warnings by removing unused argc and argv > parameters: > In function ‘main’: > warning: unused parameter ‘argc’ [-Wunused-parameter] > 158 | int main(int argc, char *argv[]) > |

[PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Muhammad Usama Anjum
Remove the following warnings by removing unused argc and argv parameters: In function ‘main’: warning: unused parameter ‘argc’ [-Wunused-parameter] 158 | int main(int argc, char *argv[]) | ^~~~ warning: unused parameter ‘argv’ [-Wunused-parameter] 158 | int main(in