Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-29 Thread Oded Gabbay
On Sun, Jan 27, 2019 at 10:32 AM gregkh wrote: > > On Sat, Jan 26, 2019 at 11:48:02PM +0200, Oded Gabbay wrote: > > On Sat, Jan 26, 2019 at 11:14 PM Arnd Bergmann wrote: > > > > > > On Sat, Jan 26, 2019 at 5:25 PM Oded Gabbay wrote: > > > > > > > > On Sat, Jan 26, 2019 at 6:06 PM Arnd Bergmann

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-27 Thread gregkh
On Sat, Jan 26, 2019 at 11:48:02PM +0200, Oded Gabbay wrote: > On Sat, Jan 26, 2019 at 11:14 PM Arnd Bergmann wrote: > > > > On Sat, Jan 26, 2019 at 5:25 PM Oded Gabbay wrote: > > > > > > On Sat, Jan 26, 2019 at 6:06 PM Arnd Bergmann wrote: > > > > > > > > On Wed, Jan 23, 2019 at 1:01 AM Oded Ga

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-26 Thread Oded Gabbay
On Sat, Jan 26, 2019 at 11:14 PM Arnd Bergmann wrote: > > On Sat, Jan 26, 2019 at 5:25 PM Oded Gabbay wrote: > > > > On Sat, Jan 26, 2019 at 6:06 PM Arnd Bergmann wrote: > > > > > > On Wed, Jan 23, 2019 at 1:01 AM Oded Gabbay wrote: > > > > > > > diff --git a/drivers/misc/habanalabs/include/hab

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-26 Thread Arnd Bergmann
On Sat, Jan 26, 2019 at 5:25 PM Oded Gabbay wrote: > > On Sat, Jan 26, 2019 at 6:06 PM Arnd Bergmann wrote: > > > > On Wed, Jan 23, 2019 at 1:01 AM Oded Gabbay wrote: > > > > > diff --git a/drivers/misc/habanalabs/include/habanalabs_device_if.h > > > b/drivers/misc/habanalabs/include/habanalabs

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-26 Thread Oded Gabbay
On Sat, Jan 26, 2019 at 6:06 PM Arnd Bergmann wrote: > > On Wed, Jan 23, 2019 at 1:01 AM Oded Gabbay wrote: > > > diff --git a/drivers/misc/habanalabs/include/habanalabs_device_if.h > > b/drivers/misc/habanalabs/include/habanalabs_device_if.h > > new file mode 100644 > > index ..9dbb

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-26 Thread Arnd Bergmann
On Wed, Jan 23, 2019 at 1:01 AM Oded Gabbay wrote: > diff --git a/drivers/misc/habanalabs/include/habanalabs_device_if.h > b/drivers/misc/habanalabs/include/habanalabs_device_if.h > new file mode 100644 > index ..9dbb7077eabd > --- /dev/null > +++ b/drivers/misc/habanalabs/include/ha

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-25 Thread Oded Gabbay
On Wed, Jan 23, 2019 at 2:55 PM Mike Rapoport wrote: > > On Wed, Jan 23, 2019 at 01:40:04PM +0100, Greg KH wrote: > > On Wed, Jan 23, 2019 at 02:28:05PM +0200, Mike Rapoport wrote: > > > On Wed, Jan 23, 2019 at 02:00:43AM +0200, Oded Gabbay wrote: > > > > +/** > > > > + * hl_device_release - relea

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-25 Thread Oded Gabbay
On Wed, Jan 23, 2019 at 2:28 PM Mike Rapoport wrote: > > On Wed, Jan 23, 2019 at 02:00:43AM +0200, Oded Gabbay wrote: > > This patch adds the habanalabs skeleton driver. The driver does nothing at > > this stage except very basic operations. It contains the minimal code to > > insmod and rmmod the

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-25 Thread Oded Gabbay
On Wed, Jan 23, 2019 at 2:49 AM Joe Perches wrote: > > On Wed, 2019-01-23 at 02:00 +0200, Oded Gabbay wrote: > > This patch adds the habanalabs skeleton driver. The driver does nothing at > > this stage except very basic operations. It contains the minimal code to > > insmod and rmmod the driver a

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-23 Thread Mike Rapoport
On Wed, Jan 23, 2019 at 01:40:04PM +0100, Greg KH wrote: > On Wed, Jan 23, 2019 at 02:28:05PM +0200, Mike Rapoport wrote: > > On Wed, Jan 23, 2019 at 02:00:43AM +0200, Oded Gabbay wrote: > > > +/** > > > + * hl_device_release - release function for habanalabs device > > > + * > > > + * @inode: poin

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-23 Thread Greg KH
On Wed, Jan 23, 2019 at 02:28:05PM +0200, Mike Rapoport wrote: > On Wed, Jan 23, 2019 at 02:00:43AM +0200, Oded Gabbay wrote: > > +/** > > + * hl_device_release - release function for habanalabs device > > + * > > + * @inode: pointer to inode structure > > + * @filp: pointer to file structure > > +

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-23 Thread Mike Rapoport
On Wed, Jan 23, 2019 at 02:00:43AM +0200, Oded Gabbay wrote: > This patch adds the habanalabs skeleton driver. The driver does nothing at > this stage except very basic operations. It contains the minimal code to > insmod and rmmod the driver and to create a /dev/hlX file per PCI device. > > Signe

Re: [PATCH 01/15] habanalabs: add skeleton driver

2019-01-22 Thread Joe Perches
On Wed, 2019-01-23 at 02:00 +0200, Oded Gabbay wrote: > This patch adds the habanalabs skeleton driver. The driver does nothing at > this stage except very basic operations. It contains the minimal code to > insmod and rmmod the driver and to create a /dev/hlX file per PCI device. trivial notes:

[PATCH 01/15] habanalabs: add skeleton driver

2019-01-22 Thread Oded Gabbay
This patch adds the habanalabs skeleton driver. The driver does nothing at this stage except very basic operations. It contains the minimal code to insmod and rmmod the driver and to create a /dev/hlX file per PCI device. Signed-off-by: Oded Gabbay --- drivers/misc/Kconfig