Re: [PATCH 01/14] tty: Improve tty_debug() macro

On Sun, 2015-11-08 at 14:30 -0500, Peter Hurley wrote: > Hi Joe, Hello Peter. > > I suggest removing __func__ from the output > > because dynamic debugging can add it. > > Done in a follow-on patch in the series because the messages needed > some (minor) context if the function name is not outpu

Re: [PATCH 01/14] tty: Improve tty_debug() macro

Hi Joe, On 11/08/2015 01:51 PM, Joe Perches wrote: > On Sun, 2015-11-08 at 13:01 -0500, Peter Hurley wrote: >> Incorporate suggestions for tty core debug macro improvements >> - printk(KERN_DEBUG) => pr_debug() >> - ##args => ##__VA_ARGS__ >> - remove do {} while() >> - output tty_name() first

Re: [PATCH 01/14] tty: Improve tty_debug() macro

On Sun, 2015-11-08 at 13:01 -0500, Peter Hurley wrote: > Incorporate suggestions for tty core debug macro improvements > - printk(KERN_DEBUG) => pr_debug() > - ##args => ##__VA_ARGS__ > - remove do {} while() > - output tty_name() first [] > diff --git a/include/linux/tty.h b/include/linux/tty.

[PATCH 01/14] tty: Improve tty_debug() macro

Incorporate suggestions for tty core debug macro improvements - printk(KERN_DEBUG) => pr_debug() - ##args => ##__VA_ARGS__ - remove do {} while() - output tty_name() first cc: Joe Perches Signed-off-by: Peter Hurley --- include/linux/tty.h | 7 ++- 1 file changed, 2 insertions(+), 5 del