Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-25 Thread Srikar Dronamraju
> > > > The first time the breakpoint is hit on a page, it replaces the text > > page with anon page. Now lets assume we insert breakpoints in all the > > pages in a range. Here each page is individually replaced by a non THP > > anonpage. (since we dont have bulk breakpoint insertion support, >

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-25 Thread Kirill A. Shutemov
On Wed, Jan 25, 2017 at 01:35:10PM -0500, Johannes Weiner wrote: > On Wed, Jan 25, 2017 at 08:55:22AM -0800, Srikar Dronamraju wrote: > > > > > > > > > For THPs page_check_address() always fails. It's better to split them > > > > > first before trying to replace. > > > > > > > > So what does this

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-25 Thread Johannes Weiner
On Wed, Jan 25, 2017 at 08:55:22AM -0800, Srikar Dronamraju wrote: > > > > > > > For THPs page_check_address() always fails. It's better to split them > > > > first before trying to replace. > > > > > > So what does this mean. uprobes simply fails to work when trying to > > > place a probe into

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-25 Thread Johannes Weiner
On Tue, Jan 24, 2017 at 07:28:13PM +0300, Kirill A. Shutemov wrote: > For THPs page_check_address() always fails. It's better to split them > first before trying to replace. > > Signed-off-by: Kirill A. Shutemov > Cc: Oleg Nesterov > Cc: Peter Zijlstra Acked-by: Johannes Weiner

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-25 Thread Kirill A. Shutemov
On Wed, Jan 25, 2017 at 08:55:22AM -0800, Srikar Dronamraju wrote: > > > > > > > For THPs page_check_address() always fails. It's better to split them > > > > first before trying to replace. > > > > > > So what does this mean. uprobes simply fails to work when trying to > > > place a probe into

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-25 Thread Rik van Riel
On Wed, 2017-01-25 at 08:55 -0800, Srikar Dronamraju wrote: > > > > > > > > > > > > > > > > For THPs page_check_address() always fails. It's better to > > > > split them > > > > first before trying to replace. > > > So what does this mean.  uprobes simply fails to work when trying > > > to > >

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-25 Thread Srikar Dronamraju
> > > > > For THPs page_check_address() always fails. It's better to split them > > > first before trying to replace. > > > > So what does this mean. uprobes simply fails to work when trying to > > place a probe into a THP memory region? > > Looks like we can end up with endless retry loop in u

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-24 Thread Kirill A. Shutemov
On Tue, Jan 24, 2017 at 02:35:59PM -0800, Andrew Morton wrote: > On Wed, 25 Jan 2017 01:22:17 +0300 "Kirill A. Shutemov" > wrote: > > > On Tue, Jan 24, 2017 at 01:28:49PM -0800, Andrew Morton wrote: > > > On Tue, 24 Jan 2017 19:28:13 +0300 "Kirill A. Shutemov" > > > wrote: > > > > > > > For T

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-24 Thread Andrew Morton
On Wed, 25 Jan 2017 01:22:17 +0300 "Kirill A. Shutemov" wrote: > On Tue, Jan 24, 2017 at 01:28:49PM -0800, Andrew Morton wrote: > > On Tue, 24 Jan 2017 19:28:13 +0300 "Kirill A. Shutemov" > > wrote: > > > > > For THPs page_check_address() always fails. It's better to split them > > > first be

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-24 Thread Kirill A. Shutemov
On Tue, Jan 24, 2017 at 01:28:49PM -0800, Andrew Morton wrote: > On Tue, 24 Jan 2017 19:28:13 +0300 "Kirill A. Shutemov" > wrote: > > > For THPs page_check_address() always fails. It's better to split them > > first before trying to replace. > > So what does this mean. uprobes simply fails to

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-24 Thread Andrew Morton
On Tue, 24 Jan 2017 19:28:13 +0300 "Kirill A. Shutemov" wrote: > For THPs page_check_address() always fails. It's better to split them > first before trying to replace. So what does this mean. uprobes simply fails to work when trying to place a probe into a THP memory region? How come nobody

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-24 Thread Rik van Riel
On Tue, 2017-01-24 at 19:28 +0300, Kirill A. Shutemov wrote: > For THPs page_check_address() always fails. It's better to split them > first before trying to replace. > > Signed-off-by: Kirill A. Shutemov > Cc: Oleg Nesterov > Cc: Peter Zijlstra Acked-by: Rik van Riel

[PATCH 01/12] uprobes: split THPs before trying replace them

2017-01-24 Thread Kirill A. Shutemov
For THPs page_check_address() always fails. It's better to split them first before trying to replace. Signed-off-by: Kirill A. Shutemov Cc: Oleg Nesterov Cc: Peter Zijlstra --- kernel/events/uprobes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/events/uprobes