[PATCH 01/12] VMCI: context implementation.

2013-01-08 Thread George Zhang
VMCI Context code maintains state for vmci and allows the driver to communicate with multiple VMs. Signed-off-by: George Zhang Acked-by: Andy king Acked-by: Dmitry Torokhov --- drivers/misc/vmw_vmci/vmci_context.c | 1214 ++ drivers/misc/vmw_vmci/vmci_context.h

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-11-22 Thread Joe Perches
On Wed, 2012-11-21 at 13:29 -0800, Dmitry Torokhov wrote: > Hi Joe, Howdy. > On Wed, Nov 21, 2012 at 01:04:46PM -0800, Joe Perches wrote: > > On Wed, 2012-11-21 at 12:31 -0800, George Zhang wrote: > > > + context = kzalloc(sizeof(*context), GFP_KERNEL); > > > + if (!context) { > > > + pr_

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-11-22 Thread Dmitry Torokhov
Hi Joe, On Wed, Nov 21, 2012 at 01:04:46PM -0800, Joe Perches wrote: > On Wed, 2012-11-21 at 12:31 -0800, George Zhang wrote: > > + context = kzalloc(sizeof(*context), GFP_KERNEL); > > + if (!context) { > > + pr_warn("Failed to allocate memory for VMCI context.\n"); > > OOM logging

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-11-21 Thread Andy King
Hi Joe, > Just some trivial notes. Thanks for taking a look! > > + pr_warn("Failed to allocate memory for VMCI context.\n"); > > OOM logging messages aren't necessary as alloc failures > are already logged with a stack trace. Noted, we'll remove all such occurrences. > Maybe just us

Re: [PATCH 01/12] VMCI: context implementation.

2012-11-21 Thread Joe Perches
On Wed, 2012-11-21 at 12:31 -0800, George Zhang wrote: > VMCI Context code maintains state for vmci and allows the driver to > communicate > with multiple VMs Just some trivial notes. > diff --git a/drivers/misc/vmw_vmci/vmci_context.c > b/drivers/misc/vmw_vmci/vmci_context.c [] It'd be nicer

[PATCH 01/12] VMCI: context implementation.

2012-11-21 Thread George Zhang
VMCI Context code maintains state for vmci and allows the driver to communicate with multiple VMs. Signed-off-by: George Zhang Signed-off-by: Dmitry Torokhov Signed-off-by: Andy King --- drivers/misc/vmw_vmci/vmci_context.c | 1223 ++ drivers/misc/vmw_vmci/vmci

[PATCH 01/12] VMCI: context implementation.

2012-11-07 Thread George Zhang
VMCI Context code maintains state for vmci and allows the driver to communicate with multiple VMs. Signed-off-by: George Zhang --- drivers/misc/vmw_vmci/vmci_context.c | 1246 ++ drivers/misc/vmw_vmci/vmci_context.h | 183 + 2 files changed, 1429 insertions

[PATCH 01/12] VMCI: context implementation.

2012-11-01 Thread George Zhang
VMCI Context code maintains state for vmci and allows the driver to communicate with multiple VMs. Signed-off-by: George Zhang --- drivers/misc/vmw_vmci/vmci_context.c | 1247 ++ drivers/misc/vmw_vmci/vmci_context.h | 183 + 2 files changed, 1430 insertions(

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-10-30 Thread Dmitry Torokhov
On Tuesday, October 30, 2012 08:46:52 AM Greg KH wrote: > On Mon, Oct 29, 2012 at 09:01:40PM -0700, Dmitry Torokhov wrote: > > Hi Greg, > > > > On Mon, Oct 29, 2012 at 07:10:58PM -0700, Greg KH wrote: > > > On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: > > > > +/* > > > > + * Relea

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-10-30 Thread Greg KH
On Mon, Oct 29, 2012 at 09:01:40PM -0700, Dmitry Torokhov wrote: > Hi Greg, > > On Mon, Oct 29, 2012 at 07:10:58PM -0700, Greg KH wrote: > > On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: > > > +/* > > > + * Releases the VMCI context. If this is the last reference to > > > + * the c

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-10-29 Thread Dmitry Torokhov
Hi Greg, On Mon, Oct 29, 2012 at 07:10:58PM -0700, Greg KH wrote: > On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: > > +/* > > + * Releases the VMCI context. If this is the last reference to > > + * the context it will be deallocated. A context is created with > > + * a reference co

Re: [PATCH 01/12] VMCI: context implementation.

2012-10-29 Thread Greg KH
On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: > +/* > + * Releases the VMCI context. If this is the last reference to > + * the context it will be deallocated. A context is created with > + * a reference count of one, and on destroy, it is removed from > + * the context list before

Re: [PATCH 01/12] VMCI: context implementation.

2012-10-29 Thread Greg KH
On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: > VMCI Context code maintains state for vmci and allows the driver to > communicate with multiple VMs. > Very minor nit, wrap your changelog comments at 72 columns or at the least, 80. Didn't checkpatch complain about that? > +/* >

[PATCH 01/12] VMCI: context implementation.

2012-10-29 Thread George Zhang
VMCI Context code maintains state for vmci and allows the driver to communicate with multiple VMs. Signed-off-by: George Zhang --- drivers/misc/vmw_vmci/vmci_context.c | 1290 ++ drivers/misc/vmw_vmci/vmci_context.h | 177 + 2 files changed, 1467 insertions