Re: [PATCH 01/11] exec: Reduce bprm->per_clear to a single bit

2020-05-28 Thread Eric W. Biederman
Linus Torvalds writes: > On Thu, May 28, 2020 at 8:45 AM Eric W. Biederman > wrote: >> >> - me->personality &= ~bprm->per_clear; >> + if (bprm->per_clear) >> + me->personality &= ~PER_CLEAR_ON_SETID;\ > > My only problem with this patch is that I find that 'per_clear'

Re: [PATCH 01/11] exec: Reduce bprm->per_clear to a single bit

2020-05-28 Thread Linus Torvalds
On Thu, May 28, 2020 at 8:45 AM Eric W. Biederman wrote: > > - me->personality &= ~bprm->per_clear; > + if (bprm->per_clear) > + me->personality &= ~PER_CLEAR_ON_SETID;\ My only problem with this patch is that I find that 'per_clear' thing to be a horrid horrid name, Ob

[PATCH 01/11] exec: Reduce bprm->per_clear to a single bit

2020-05-28 Thread Eric W. Biederman
The bprm->per_clear field only takes the values 0 and PER_CLEAR_ON_SETID. Reduce the field to a signle bit to make it clear that the only question is should the dangerous personality bits be cleared or not. Update the documentation of the security lsm hooks. Signed-off-by: "Eric W. Biederman"