Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware

Hi, On Wed, Dec 11, 2013 at 4:05 AM, Maxime Ripard wrote: > Hi, > > On Mon, Dec 09, 2013 at 10:43:29AM +0800, Chen-Yu Tsai wrote: >> >> @@ -2759,15 +2760,18 @@ struct stmmac_priv *stmmac_dvr_probe(struct >> >> device *device, >> >> } >> >> } >> >> >> >> + clk_disable_unpr

Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware

Hi, On Mon, Dec 09, 2013 at 10:43:29AM +0800, Chen-Yu Tsai wrote: > >> @@ -2759,15 +2760,18 @@ struct stmmac_priv *stmmac_dvr_probe(struct device > >> *device, > >> } > >> } > >> > >> + clk_disable_unprepare(priv->stmmac_clk); > >> + > > > > Hu? Why do you disable the cloc

Re: [linux-sunxi] Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware

Hi Chen-Yu, It seems this patch is not enough, gmac won't work for me with this patchset (*), unless I boot with an uboot which also has the gmac patches. Regards, Hans *) see my sunxi-test tree where I've dropped your old version and added this version. -- To unsubscribe from this list: send

Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware

Hi Peppe, On Mon, Dec 9, 2013 at 3:14 PM, Giuseppe CAVALLARO wrote: > Hello Chen-Yu > > > On 12/6/2013 6:29 PM, Chen-Yu Tsai wrote: >> >> Signed-off-by: Chen-Yu Tsai >> --- >> >> Guiseppe previously stated that the "stmmaceth" clock is the >> main clock that drives the IP. The stmmac driver does

Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware

Hello Chen-Yu On 12/6/2013 6:29 PM, Chen-Yu Tsai wrote: Signed-off-by: Chen-Yu Tsai --- Guiseppe previously stated that the "stmmaceth" clock is the main clock that drives the IP. The stmmac driver does not enable this clock during the probe phase. When the driver is built in to the kernel, th

Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware

Hi, On Sat, Dec 7, 2013 at 6:33 PM, Maxime Ripard wrote: > Hi, > > On Sat, Dec 07, 2013 at 01:29:34AM +0800, Chen-Yu Tsai wrote: >> Signed-off-by: Chen-Yu Tsai >> --- >> >> Guiseppe previously stated that the "stmmaceth" clock is the >> main clock that drives the IP. The stmmac driver does not >

Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware

Hi, On Sat, Dec 07, 2013 at 01:29:34AM +0800, Chen-Yu Tsai wrote: > Signed-off-by: Chen-Yu Tsai > --- > > Guiseppe previously stated that the "stmmaceth" clock is the > main clock that drives the IP. The stmmac driver does not > enable this clock during the probe phase. When the driver is > buil

[PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware

Signed-off-by: Chen-Yu Tsai --- Guiseppe previously stated that the "stmmaceth" clock is the main clock that drives the IP. The stmmac driver does not enable this clock during the probe phase. When the driver is built in to the kernel, this is fine because the clock maybe on by default, or the bo