Re: [PATCH 01/10] mm/hmm: use reference counting for HMM struct

2019-02-20 Thread John Hubbard
On 2/20/19 4:37 PM, Jerome Glisse wrote: On Wed, Feb 20, 2019 at 04:32:09PM -0800, John Hubbard wrote: On 2/20/19 4:15 PM, Jerome Glisse wrote: On Wed, Feb 20, 2019 at 04:06:50PM -0800, John Hubbard wrote: On 2/20/19 3:59 PM, Jerome Glisse wrote: On Wed, Feb 20, 2019 at 03:47:50PM -0800, John

Re: [PATCH 01/10] mm/hmm: use reference counting for HMM struct

2019-02-20 Thread Jerome Glisse
On Wed, Feb 20, 2019 at 04:32:09PM -0800, John Hubbard wrote: > On 2/20/19 4:15 PM, Jerome Glisse wrote: > > On Wed, Feb 20, 2019 at 04:06:50PM -0800, John Hubbard wrote: > > > On 2/20/19 3:59 PM, Jerome Glisse wrote: > > > > On Wed, Feb 20, 2019 at 03:47:50PM -0800, John Hubbard wrote: > > > > > O

Re: [PATCH 01/10] mm/hmm: use reference counting for HMM struct

2019-02-20 Thread John Hubbard
On 2/20/19 4:15 PM, Jerome Glisse wrote: On Wed, Feb 20, 2019 at 04:06:50PM -0800, John Hubbard wrote: On 2/20/19 3:59 PM, Jerome Glisse wrote: On Wed, Feb 20, 2019 at 03:47:50PM -0800, John Hubbard wrote: On 1/29/19 8:54 AM, jgli...@redhat.com wrote: From: Jérôme Glisse Every time i read t

Re: [PATCH 01/10] mm/hmm: use reference counting for HMM struct

2019-02-20 Thread Jerome Glisse
On Wed, Feb 20, 2019 at 04:06:50PM -0800, John Hubbard wrote: > On 2/20/19 3:59 PM, Jerome Glisse wrote: > > On Wed, Feb 20, 2019 at 03:47:50PM -0800, John Hubbard wrote: > > > On 1/29/19 8:54 AM, jgli...@redhat.com wrote: > > > > From: Jérôme Glisse > > > > > > > > Every time i read the code to

Re: [PATCH 01/10] mm/hmm: use reference counting for HMM struct

2019-02-20 Thread John Hubbard
On 2/20/19 3:59 PM, Jerome Glisse wrote: On Wed, Feb 20, 2019 at 03:47:50PM -0800, John Hubbard wrote: On 1/29/19 8:54 AM, jgli...@redhat.com wrote: From: Jérôme Glisse Every time i read the code to check that the HMM structure does not vanish before it should thanks to the many lock protecti

Re: [PATCH 01/10] mm/hmm: use reference counting for HMM struct

2019-02-20 Thread Jerome Glisse
On Wed, Feb 20, 2019 at 03:47:50PM -0800, John Hubbard wrote: > On 1/29/19 8:54 AM, jgli...@redhat.com wrote: > > From: Jérôme Glisse > > > > Every time i read the code to check that the HMM structure does not > > vanish before it should thanks to the many lock protecting its removal > > i get a

Re: [PATCH 01/10] mm/hmm: use reference counting for HMM struct

2019-02-20 Thread John Hubbard
On 1/29/19 8:54 AM, jgli...@redhat.com wrote: From: Jérôme Glisse Every time i read the code to check that the HMM structure does not vanish before it should thanks to the many lock protecting its removal i get a headache. Switch to reference counting instead it is much easier to follow and har

[PATCH 01/10] mm/hmm: use reference counting for HMM struct

2019-01-29 Thread jglisse
From: Jérôme Glisse Every time i read the code to check that the HMM structure does not vanish before it should thanks to the many lock protecting its removal i get a headache. Switch to reference counting instead it is much easier to follow and harder to break. This also remove some code that is