Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data

2007-08-16 Thread Jens Axboe
On Thu, Aug 16 2007, Neil Brown wrote: > On Thursday August 16, [EMAIL PROTECTED] wrote: > > > 2 and 3 are very simple changes that - I think - make it clearer what > > > is happening. > > > > To be honest, I don't see much win in using blk_rq_data() over > > bio_data() at all. I'd much much rathe

Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data

2007-08-16 Thread Jens Axboe
On Thu, Aug 16 2007, Neil Brown wrote: > On Thursday August 16, [EMAIL PROTECTED] wrote: > > > 2 and 3 are very simple changes that - I think - make it clearer what > > > is happening. > > > > To be honest, I don't see much win in using blk_rq_data() over > > bio_data() at all. I'd much much rathe

Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data

2007-08-16 Thread Neil Brown
On Thursday August 16, [EMAIL PROTECTED] wrote: > > 2 and 3 are very simple changes that - I think - make it clearer what > > is happening. > > To be honest, I don't see much win in using blk_rq_data() over > bio_data() at all. I'd much much rather just see it go away! > Well, as it is always th

Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data

2007-08-16 Thread Jens Axboe
On Thu, Aug 16 2007, Neil Brown wrote: > On Thursday August 16, [EMAIL PROTECTED] wrote: > > On Thu, Aug 16 2007, NeilBrown wrote: > > > > > > Almost every call to bio_data is for the first bio > > > in a request. A future patch will add some accounting > > > information to 'struct request' which

Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data

2007-08-16 Thread Neil Brown
On Thursday August 16, [EMAIL PROTECTED] wrote: > On Thu, Aug 16 2007, NeilBrown wrote: > > > > Almost every call to bio_data is for the first bio > > in a request. A future patch will add some accounting > > information to 'struct request' which will need to be > > used to find the start of the

Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data

2007-08-16 Thread Jens Axboe
On Thu, Aug 16 2007, NeilBrown wrote: > > Almost every call to bio_data is for the first bio > in a request. A future patch will add some accounting > information to 'struct request' which will need to be > used to find the start of the request in the bio. > So replace bio_data with blk_rq_data w

[PATCH 002 of 5] Replace bio_data with blk_rq_data

2007-08-15 Thread NeilBrown
Almost every call to bio_data is for the first bio in a request. A future patch will add some accounting information to 'struct request' which will need to be used to find the start of the request in the bio. So replace bio_data with blk_rq_data which takes a 'struct request *' The one exception