Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-14 Thread Greg KH
On Sat, Dec 14, 2013 at 02:21:36PM -0800, Colin Cross wrote: > On Sat, Dec 14, 2013 at 1:44 PM, Greg KH wrote: > > On Sat, Dec 14, 2013 at 01:10:38PM -0800, Colin Cross wrote: > >> On Sat, Dec 14, 2013 at 8:52 AM, Greg KH > >> wrote: > >> > On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz w

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-14 Thread Colin Cross
On Sat, Dec 14, 2013 at 1:44 PM, Greg KH wrote: > On Sat, Dec 14, 2013 at 01:10:38PM -0800, Colin Cross wrote: >> On Sat, Dec 14, 2013 at 8:52 AM, Greg KH wrote: >> > On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: >> >> + idev->debug_root = debugfs_create_dir("ion", NULL); >> >>

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-14 Thread Greg KH
On Sat, Dec 14, 2013 at 01:10:38PM -0800, Colin Cross wrote: > On Sat, Dec 14, 2013 at 8:52 AM, Greg KH wrote: > > On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: > >> + idev->debug_root = debugfs_create_dir("ion", NULL); > >> + if (IS_ERR_OR_NULL(idev->debug_root)) > >> +

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-14 Thread Colin Cross
On Sat, Dec 14, 2013 at 8:52 AM, Greg KH wrote: > On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: >> + idev->debug_root = debugfs_create_dir("ion", NULL); >> + if (IS_ERR_OR_NULL(idev->debug_root)) >> + pr_err("ion: failed to create debug files.\n"); > > There's no

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-14 Thread John Stultz
On 12/14/2013 11:43 AM, John Stultz wrote: > On 12/14/2013 09:06 AM, Greg KH wrote: >> Everything works fine until this one (i.e. the driver doesn't build), >> but after applying this patch, the build breaks with a ton of undefined >> symbols at link time, here's a sample of some of them: >> >> ERR

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-14 Thread John Stultz
On 12/14/2013 09:06 AM, Greg KH wrote: > On Fri, Dec 13, 2013 at 05:18:00PM -0800, John Stultz wrote: >> 0117-ion-Reenable-the-build.patch - This can be applied to the end of >> the series, or folded into the last patch "ion: Update system heap >> shrinker to use the new count/scan interface" > Was

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-14 Thread Greg KH
On Fri, Dec 13, 2013 at 05:18:00PM -0800, John Stultz wrote: > 0117-ion-Reenable-the-build.patch - This can be applied to the end of > the series, or folded into the last patch "ion: Update system heap > shrinker to use the new count/scan interface" Was there a 0116 patch somewhere? Everything wo

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-14 Thread Greg KH
On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: > + idev->debug_root = debugfs_create_dir("ion", NULL); > + if (IS_ERR_OR_NULL(idev->debug_root)) > + pr_err("ion: failed to create debug files.\n"); There's no need to check for this at all, you just printed out an e

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-13 Thread John Stultz
On 12/13/2013 03:50 PM, Greg KH wrote: > On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: >> From: Rebecca Schultz Zavin >> >> Signed-off-by: Rebecca Schultz Zavin >> [jstultz: Squished in Colin Cross' move to staging change] >> Signed-off-by: John Stultz >> --- >> drivers/staging/a

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-13 Thread John Stultz
On 12/13/2013 03:54 PM, John Stultz wrote: > On 12/13/2013 03:50 PM, Greg KH wrote: >> On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: >>> From: Rebecca Schultz Zavin >>> >>> Signed-off-by: Rebecca Schultz Zavin >>> [jstultz: Squished in Colin Cross' move to staging change] >>> Signe

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-13 Thread John Stultz
On 12/13/2013 03:50 PM, Greg KH wrote: > On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: >> From: Rebecca Schultz Zavin >> >> Signed-off-by: Rebecca Schultz Zavin >> [jstultz: Squished in Colin Cross' move to staging change] >> Signed-off-by: John Stultz >> --- >> drivers/staging/a

Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

2013-12-13 Thread Greg KH
On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote: > From: Rebecca Schultz Zavin > > Signed-off-by: Rebecca Schultz Zavin > [jstultz: Squished in Colin Cross' move to staging change] > Signed-off-by: John Stultz > --- > drivers/staging/android/Kconfig |2 + > driv