Re: [PATCH 00/22] x86, objtool: several fixes/improvements

2019-09-27 Thread Nick Desaulniers
On Thu, Jul 18, 2019 at 3:26 PM Nick Desaulniers wrote: > > On Tue, Jul 16, 2019 at 4:17 PM Josh Poimboeuf wrote: > > > > > > > 2) There's also an issue in clang where a large switch table had a > > > > > bunch > > > > >of unused (bad) entries. It's not a code correctness issue, but > > > >

Re: [PATCH 00/22] x86, objtool: several fixes/improvements

2019-07-18 Thread Nick Desaulniers
On Tue, Jul 16, 2019 at 4:17 PM Josh Poimboeuf wrote: > > On Mon, Jul 15, 2019 at 02:45:39PM -0700, Nick Desaulniers wrote: > > For a defconfig, that's the only issue I see. > > (Note that I just landed https://reviews.llvm.org/rL366130 for fixing > > up bugs from loop unrolling loops containing a

Re: [PATCH 00/22] x86, objtool: several fixes/improvements

2019-07-16 Thread Josh Poimboeuf
On Mon, Jul 15, 2019 at 02:45:39PM -0700, Nick Desaulniers wrote: > For a defconfig, that's the only issue I see. > (Note that I just landed https://reviews.llvm.org/rL366130 for fixing > up bugs from loop unrolling loops containing asm goto with Clang, so > anyone else testing w/ clang will see fe

Re: [PATCH 00/22] x86, objtool: several fixes/improvements

2019-07-15 Thread Nick Desaulniers
On Mon, Jul 15, 2019 at 12:38 PM Josh Poimboeuf wrote: > > On Sun, Jul 14, 2019 at 07:36:55PM -0500, Josh Poimboeuf wrote: > > There have been a lot of objtool bug reports lately, mainly related to > > Clang and BPF. As part of fixing those bugs, I added some improvements > > to objtool which unc

Re: [PATCH 00/22] x86, objtool: several fixes/improvements

2019-07-15 Thread Josh Poimboeuf
On Sun, Jul 14, 2019 at 07:36:55PM -0500, Josh Poimboeuf wrote: > There have been a lot of objtool bug reports lately, mainly related to > Clang and BPF. As part of fixing those bugs, I added some improvements > to objtool which uncovered yet more bugs (some kernel, some objtool). > > I've given

Re: [PATCH 00/22] x86, objtool: several fixes/improvements

2019-07-15 Thread Peter Zijlstra
On Sun, Jul 14, 2019 at 07:36:55PM -0500, Josh Poimboeuf wrote: > There have been a lot of objtool bug reports lately, mainly related to > Clang and BPF. As part of fixing those bugs, I added some improvements > to objtool which uncovered yet more bugs (some kernel, some objtool). > > I've given

[PATCH 00/22] x86, objtool: several fixes/improvements

2019-07-14 Thread Josh Poimboeuf
There have been a lot of objtool bug reports lately, mainly related to Clang and BPF. As part of fixing those bugs, I added some improvements to objtool which uncovered yet more bugs (some kernel, some objtool). I've given these patches a lot of testing with both GCC and Clang. More compile test