Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-08-01 Thread Sami Tolvanen
Hi Petr, On Thu, Aug 1, 2024 at 4:22 AM Petr Pavlu wrote: > > STG is an interesting tool. I've played with it a bit last year. To be > frank, I was surprised to see a new tool being proposed by Google to > generate modversion CRCs from DWARF instead of potentially extending > your STG project for

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-08-01 Thread Petr Pavlu
On 7/26/24 23:05, Sami Tolvanen wrote: > On Mon, Jul 22, 2024 at 8:20 AM Petr Pavlu wrote: >> >> From my perspective, I'm okay if gendwarfksyms doesn't provide >> functionality to compare a new object file with its reference symtypes >> file. >> >> As mentioned, genksyms has this functionality but

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-31 Thread Neal Gompa
On Friday, July 26, 2024 5:05:22 PM EDT Sami Tolvanen wrote: > Hi Petr, > > On Mon, Jul 22, 2024 at 8:20 AM Petr Pavlu wrote: > > From my perspective, I'm okay if gendwarfksyms doesn't provide > > functionality to compare a new object file with its reference symtypes > > file. > > > > As mention

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-26 Thread Sami Tolvanen
Hi Petr, On Mon, Jul 22, 2024 at 8:20 AM Petr Pavlu wrote: > > From my perspective, I'm okay if gendwarfksyms doesn't provide > functionality to compare a new object file with its reference symtypes > file. > > As mentioned, genksyms has this functionality but I actually think the > way it works

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-22 Thread Petr Pavlu
On 7/15/24 22:39, Sami Tolvanen wrote: > On Wed, Jul 10, 2024 at 7:30 AM Petr Pavlu wrote: >> On 6/17/24 19:58, Sami Tolvanen wrote: >>> The first 12 patches of this series add a small tool for computing >>> symbol versions from DWARF, called gendwarfksyms. When passed a list >>> of exported symbo

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-18 Thread Sami Tolvanen
On Tue, Jul 16, 2024 at 12:12 AM Greg Kroah-Hartman wrote: > > > After replacement: > > > > union { > > u64 new_member; > > struct { > > u8 __kabi_reserved_1[8]; > > }; > > } > > Note, such a thing would only be for the distros that w

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-16 Thread Greg Kroah-Hartman
On Mon, Jul 15, 2024 at 08:39:59PM +, Sami Tolvanen wrote: > If using unions here is acceptable to everyone, a simple solution > would be to use a known name prefix for the reserved members and teach > gendwarfksyms to only print out the original type for the replaced > ones. For example: > >

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-15 Thread Sami Tolvanen
Hi Petr, On Wed, Jul 10, 2024 at 7:30 AM Petr Pavlu wrote: > > On 6/17/24 19:58, Sami Tolvanen wrote: > > Hi folks, > > > > This series implements CONFIG_MODVERSIONS for Rust, an important > > feature for distributions like Android that want to ship Rust > > kernel modules, and depend on modversi

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-10 Thread Petr Pavlu
On 6/17/24 19:58, Sami Tolvanen wrote: > Hi folks, > > This series implements CONFIG_MODVERSIONS for Rust, an important > feature for distributions like Android that want to ship Rust > kernel modules, and depend on modversions to help ensure module ABI > compatibility. Thanks for working on this

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Luis Chamberlain
On Tue, Jun 18, 2024 at 02:19:47PM -0700, Sami Tolvanen wrote: > Hi Luis, > > On Tue, Jun 18, 2024 at 12:42:51PM -0700, Luis Chamberlain wrote: > > a) Ensure correctness for all users / tools, so that proper plumbing is > >really done. By considering all symbols you increase your scope of > >

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Sami Tolvanen
Hi Luis, On Tue, Jun 18, 2024 at 12:42:51PM -0700, Luis Chamberlain wrote: > On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > > The first 12 patches of this series add a small tool for computing > > symbol versions from DWARF, called gendwarfksyms. When passed a list > > of exporte

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Sami Tolvanen
On Wed, Jun 19, 2024 at 04:03:45AM +0900, Masahiro Yamada wrote: > On Wed, Jun 19, 2024 at 2:18 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Jun 19, 2024 at 01:50:36AM +0900, Masahiro Yamada wrote: > > > On Wed, Jun 19, 2024 at 1:44 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > That's cool

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Sami Tolvanen
Hi Masahiro, On Wed, Jun 19, 2024 at 01:28:21AM +0900, Masahiro Yamada wrote: > I am surprised at someone who attempts to add another variant of genksyms. The options are rather limited if we want Rust modules that are compatible with modversions. We either come up with a way to version Rust symb

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Luis Chamberlain
On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > Hi folks, > > This series implements CONFIG_MODVERSIONS for Rust, an important > feature for distributions like Android that want to ship Rust > kernel modules, and depend on modversions to help ensure module ABI > compatibility. >

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Masahiro Yamada
On Wed, Jun 19, 2024 at 2:18 AM Greg Kroah-Hartman wrote: > > On Wed, Jun 19, 2024 at 01:50:36AM +0900, Masahiro Yamada wrote: > > On Wed, Jun 19, 2024 at 1:44 AM Greg Kroah-Hartman > > wrote: > > > > > > On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > > > > Hi folks, > > > > > >

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Greg Kroah-Hartman
On Wed, Jun 19, 2024 at 01:50:36AM +0900, Masahiro Yamada wrote: > On Wed, Jun 19, 2024 at 1:44 AM Greg Kroah-Hartman > wrote: > > > > On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > > > Hi folks, > > > > > > This series implements CONFIG_MODVERSIONS for Rust, an important > > > f

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Masahiro Yamada
On Wed, Jun 19, 2024 at 1:44 AM Greg Kroah-Hartman wrote: > > On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > > Hi folks, > > > > This series implements CONFIG_MODVERSIONS for Rust, an important > > feature for distributions like Android that want to ship Rust > > kernel modules,

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Greg Kroah-Hartman
On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > Hi folks, > > This series implements CONFIG_MODVERSIONS for Rust, an important > feature for distributions like Android that want to ship Rust > kernel modules, and depend on modversions to help ensure module ABI > compatibility. >

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Masahiro Yamada
On Tue, Jun 18, 2024 at 2:58 AM Sami Tolvanen wrote: > > Hi folks, > > This series implements CONFIG_MODVERSIONS for Rust, an important > feature for distributions like Android that want to ship Rust > kernel modules, and depend on modversions to help ensure module ABI > compatibility. > > There h

[PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-17 Thread Sami Tolvanen
Hi folks, This series implements CONFIG_MODVERSIONS for Rust, an important feature for distributions like Android that want to ship Rust kernel modules, and depend on modversions to help ensure module ABI compatibility. There have been earlier proposals [1][2] that would allow Rust modules to coe